[consensus] Extend the accepted tx versions to 3
Changes PlannedPublic
Actions

Authored by Fabien on Mar 2 2023, 13:50.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

This diff makes tx version 3 standard and consensus compliant after wellington activation. The versions 2 and 3 have similar meaning.

Depends on D13223.

Test Plan

ninja all check-extended
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tx_version3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22214
Build 44063: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-clang-tidy · build-clang
Build 44062: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 2 2023, 13:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2023, 13:50

Fabien requested review of this revision.Mar 2 2023, 13:50

Harbormaster completed remote builds in B22214: Diff 38236.Mar 2 2023, 14:11

There is a test in mempool_accept.py checking that version 3 is rejected from the mempool. Should this be addressed in this diff?

self.log.info('Some nonstandard transactions')
tx = FromHex(CTransaction(), raw_tx_reference)
tx.nVersion = 3  # A version currently non-standard
self.check_mempool_result(
    result_expected=[
        {'txid': tx.rehash(), 'allowed': False, 'reject-reason': 'version'}],
    rawtxs=[ToHex(tx)],
)

It is not wrong right now, but it will fail after wellington.

Fabien planned changes to this revision.Mar 3 2023, 07:40

Fix mempool_accept.py after activation

PiRK accepted this revision.Mar 3 2023, 08:26

This revision is now accepted and ready to land.Mar 3 2023, 08:26

Harbormaster completed remote builds in B22236: Diff 38264.Mar 3 2023, 08:42

Extend testing with version 3 in bip68 test

Harbormaster completed remote builds in B22238: Diff 38268.Mar 3 2023, 10:28

After discussion with the various involved actors, I decided the benefit does not warrant the maintenance cost for this change.