Are we 100% sure that new Blob([value]).size will always be the same as the length of the generated op_return script?

I let this slide in the last diff but questioning it now. Seems like we should just use the exact same function for both just to be sure.

I'm open to the Blob but we need more certainty than just a few unit tests.

From this, seems like Blob.text() could be more appropriate: https://developer.mozilla.org/en-US/docs/Web/API/Blob

Still, seems risky using two different approaches. We might as well calculate the backend length of the alias and parse that, rather than create a front-end construct that should be the same.

Please either

• Provide some info / justification of why the blob approach is ok (for example, is this the method being used in the library that generatees op_return scripts?)
• Instead of blob, calculate the bytesize by creating the op_return script and reading the length

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

Let's delete all references to new Blob

No need to have this in the unit test now that this approach is not used in the app.

Please refactor these unit tests so that they are checking for an expected hardcoded length instead of a Blob-based length.

sorry, missed this one in the last review.

• input param for this function should be aliasHexBytes

then

const aliasByteCount = aliasHexBytes.length / 2
switch (aliasByteCount) ...

typo registratioFee

doesn't need to be handled here but at least needs to be tracked

let's keep alias as the input, and do the conversion to bytes and then to bytecount in this function

For all cases getAliasRegistrationFee is called, the alias input is available. It makes sense to keep it this way rather than modify the input in 3 of the 4 times the function is called.