Page MenuHomePhabricator

[tg bot] use token instead of etoken in variables
ClosedPublic

Authored by bytesofman on Mar 11 2023, 00:35.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC036a7a2f0abb: [tg bot] use token instead of etoken in variables
Summary

T2972

Depends on D13281

When it comes to camel case variable naming, ambiguity sometimes can arise between the use of 'etoken' and 'eToken'. To remove this problem, just use 'token' in variable names. Use 'eToken' in user-facing strings.

Test Plan

In parse.js, ctrl+f 'etoken', only results are strings and not variable names
npm test
npm run msgs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
telegram-bot-mega-branch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22340
Build 44306: Build Diff
Build 44305: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Mar 11 2023, 10:52
emack added a subscriber: emack.

The data structure inside parse.js is using isTokenTx as a param whereas your unit tests are expecting isEtokenTx.

image.png (377×747 px, 48 KB)

image.png (227×336 px, 14 KB)

This revision now requires changes to proceed.Mar 11 2023, 10:52
This revision is now accepted and ready to land.Mar 12 2023, 07:20