Page MenuHomePhabricator
Differential D13282

[tg bot] use token instead of etoken in variables
ClosedPublic
Actions

Authored by bytesofman on Mar 11 2023, 00:35.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC036a7a2f0abb: [tg bot] use token instead of etoken in variables
Summary

T2972

Depends on D13281

When it comes to camel case variable naming, ambiguity sometimes can arise between the use of 'etoken' and 'eToken'. To remove this problem, just use 'token' in variable names. Use 'eToken' in user-facing strings.

Test Plan

In parse.js, ctrl+f 'etoken', only results are strings and not variable names
npm test
npm run msgs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
telegram-bot-mega-branch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22340
Build 44306: Build Diff
Build 44305: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 11 2023, 00:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 00:35
bytesofman requested review of this revision.Mar 11 2023, 00:35
Harbormaster completed remote builds in B22340: Diff 38409.Mar 11 2023, 00:35
bytesofman added a child revision: D13283: [tg bot] conditionally render tx or txs depending on txcount.Mar 11 2023, 00:39
emack requested changes to this revision.Mar 11 2023, 10:52
emack added a subscriber: emack.

The data structure inside parse.js is using isTokenTx as a param whereas your unit tests are expecting isEtokenTx.

image.png (377×747 px, 48 KB)

image.png (227×336 px, 14 KB)

This revision now requires changes to proceed.Mar 11 2023, 10:52
bytesofman updated this revision to Diff 38438.Mar 11 2023, 18:01

Updating mocks

Harbormaster completed remote builds in B22368: Diff 38438.Mar 11 2023, 18:01
emack accepted this revision.Mar 12 2023, 07:20
This revision is now accepted and ready to land.Mar 12 2023, 07:20
emack mentioned this in D13296: [tg bot] Clean strings that could contain special characters before adding to telegram html msg.Mar 12 2023, 07:23
bytesofman updated this revision to Diff 38447.Mar 12 2023, 19:12

rebase

Harbormaster completed remote builds in B22377: Diff 38447.Mar 12 2023, 19:12
Closed by commit rABC036a7a2f0abb: [tg bot] use token instead of etoken in variables (authored by bytesofman). · Explain WhyMar 12 2023, 22:02
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC036a7a2f0abb: [tg bot] use token instead of etoken in variables.

Revision Contents
Changeset List

PathSize
web/
ecash-telegram-bot/
22 lines

Diff 38409

View Options

web/ecash-telegram-bot/parse.js

Loading...