Page MenuHomePhabricator
Differential D13296

[tg bot] Clean strings that could contain special characters before adding to telegram html msg
ClosedPublic
Actions

Authored by bytesofman on Mar 11 2023, 18:59.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC857569aa36a8: [tg bot] Clean strings that could contain special characters before adding to…
Summary

T2972

Depends on D13286

Add function prepareStringForTelegramHTML and unit tests. Apply to strings that could contain '<', '>', or '&' characters. Add test where these strings do contain such characters.

Test Plan

npm test
npm run msgs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
telegram-bot-mega-branch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22369
Build 44364: Build Diff
Build 44363: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 11 2023, 18:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 18:59
bytesofman requested review of this revision.Mar 11 2023, 18:59
Harbormaster completed remote builds in B22369: Diff 38439.Mar 11 2023, 18:59
bytesofman added a child revision: D13297: [tg bot] Pass txid to link etoken name to genesis tx.Mar 11 2023, 19:14
emack requested changes to this revision.Mar 12 2023, 07:23
emack added a subscriber: emack.

Needs a rebase since you updated mocks in part 4 D13282
The subsequent diffs will also need to be rebased

image.png (276×721 px, 47 KB)

This revision now requires changes to proceed.Mar 12 2023, 07:23
bytesofman updated this revision to Diff 38452.Mar 12 2023, 19:13

rebase

Harbormaster completed remote builds in B22382: Diff 38452.Mar 12 2023, 19:13
emack accepted this revision.Mar 12 2023, 21:08
This revision is now accepted and ready to land.Mar 12 2023, 21:08
Closed by commit rABC857569aa36a8: [tg bot] Clean strings that could contain special characters before adding to… (authored by bytesofman). · Explain WhyMar 12 2023, 22:02
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC857569aa36a8: [tg bot] Clean strings that could contain special characters before adding to….

Revision Contents
Changeset List

PathSize
web/
ecash-telegram-bot/
26 lines
scripts/
6 lines
test/
mocks/
1639 lines
8 lines
32 lines

Diff 38439

View Options

web/ecash-telegram-bot/parse.js

Loading...
View Options

web/ecash-telegram-bot/scripts/generateMocks.js

Loading...
View Options

web/ecash-telegram-bot/test/mocks/blocks.js

Loading...
View Options

web/ecash-telegram-bot/test/mocks/templates.js

Loading...
View Options

web/ecash-telegram-bot/test/parse.js

Loading...