Page MenuHomePhabricator
Differential D13310

net: Simplify ProcessGetBlockData execution by removing send flag.
ClosedPublic
Actions

Authored by PiRK on Mar 13 2023, 12:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC577519bea436: net: Simplify ProcessGetBlockData execution by removing send flag.
Summary

Setting the send flag to false can be replaced by simply returning.

This is a partial backport of core#21235
https://github.com/bitcoin/bitcoin/pull/21235/commits/fae77b9e6dc9e59b355d56df49c4d9685b6f40a4

Depends on D13309

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 13 2023, 12:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 13 2023, 12:31
PiRK requested review of this revision.Mar 13 2023, 12:31
teamcity edited the summary of this revision. (Show Details)Mar 13 2023, 12:31
PiRK added inline comments.Mar 13 2023, 12:32
src/net_processing.cpp
2570 ↗(On Diff #38496)

The negation and early return is done in the next commit, with the indentation change in the following block

PiRK added a child revision: D13311: remove indentation level in ProcessGetBlockData.Mar 13 2023, 12:34
Fabien accepted this revision.Mar 13 2023, 12:47
This revision is now accepted and ready to land.Mar 13 2023, 12:47
Harbormaster completed remote builds in B22404: Diff 38496.Mar 13 2023, 13:07
Closed by commit rABC577519bea436: net: Simplify ProcessGetBlockData execution by removing send flag. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by PiRK). · Explain WhyMar 13 2023, 15:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC577519bea436: net: Simplify ProcessGetBlockData execution by removing send flag..

Revision Contents
Changeset List

PathSize
src/
29 lines

Diff 38510

View Options

src/net_processing.cpp

Loading...