[lint] improve handling of escaped % in lint-format-strings
ClosedPublic
Actions

Authored by PiRK on Mar 14 2023, 07:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2eab7ff3bf5f: [lint] improve handling of escaped % in lint-format-strings

Summary

The linter considered 2 or more consecutive "%" as an escaped "%" character.
This fixes the problem: now the linter escapes only even numbers of "%" characters.

Test Plan

Run unit tests (via doctest):

test/lint/lint-format-strings.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 14 2023, 07:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2023, 07:59

PiRK requested review of this revision.Mar 14 2023, 07:59

PiRK mentioned this in D13312: net: Avoid calling getnameinfo when formatting IP addresses.Mar 14 2023, 08:03

PiRK added a child revision: D13312: net: Avoid calling getnameinfo when formatting IP addresses.Mar 14 2023, 08:04

Harbormaster completed remote builds in B22424: Diff 38531.Mar 14 2023, 08:14

Fabien accepted this revision.Mar 14 2023, 08:19

This revision is now accepted and ready to land.Mar 14 2023, 08:19

Closed by commit rABC2eab7ff3bf5f: [lint] improve handling of escaped % in lint-format-strings (authored by PiRK). · Explain WhyMar 14 2023, 08:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2eab7ff3bf5f: [lint] improve handling of escaped % in lint-format-strings.

Revision Contents
Changeset List

Path

Size

test/

lint/

lint-format-strings-tests.txt

5 lines

lint-format-strings.py

13 lines

Diff 38535

View Options

test/lint/lint-format-strings-tests.txt