Page MenuHomePhabricator
Differential D13325

p2p, refactor: make NetPermissionFlags a uint32 enum class
ClosedPublic
Actions

Authored by PiRK on Mar 14 2023, 10:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2cf2f8f31a9f: p2p, refactor: make NetPermissionFlags a uint32 enum class
Summary

https://github.com/bitcoin/bitcoin/pull/21506/commits/7b55a9449778c5ac89799ce4c607c8c8d797ddfb

p2p: NetPermissions::HasFlag() pass flags param by value

https://github.com/bitcoin/bitcoin/pull/21506/commits/810d0929c1626bba141af3f779a3c9cd6ece7e75

p2p, refactor: make NetPermissionFlags a uint32 enum class

and define/update operation methods to handle type conversions explicitly. See
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-oper
for more info.

This eliminates the class of bugs like D13323

This concludes backport of core#21506
Depends on D13326

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 14 2023, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2023, 10:24
PiRK requested review of this revision.Mar 14 2023, 10:24
teamcity edited the summary of this revision. (Show Details)Mar 14 2023, 10:24
PiRK planned changes to this revision.Mar 14 2023, 10:40

I have to rebase this and move it before the enum renaming in D13324 to allow usage of None and All without shadowing other (non class) enums.

Harbormaster completed remote builds in B22434: Diff 38543.Mar 14 2023, 10:44
PiRK updated this revision to Diff 38545.Mar 14 2023, 10:56
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D13326: scripted-diff: add NetPermissionFlags scopes where not already present.

rebase onto D13326 (adding missing scopes)
I moved this before D13324 so that the new enum names won't conflict with other enums

PiRK removed a parent revision: D13324: scripted-diff: rename NetPermissionFlags enumerators.Mar 14 2023, 11:02
PiRK added a child revision: D13324: scripted-diff: rename NetPermissionFlags enumerators.Mar 14 2023, 11:03
Harbormaster completed remote builds in B22436: Diff 38545.Mar 14 2023, 11:09
Fabien accepted this revision.Mar 14 2023, 11:15
This revision is now accepted and ready to land.Mar 14 2023, 11:15
Closed by commit rABC2cf2f8f31a9f: p2p, refactor: make NetPermissionFlags a uint32 enum class (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyMar 14 2023, 11:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2cf2f8f31a9f: p2p, refactor: make NetPermissionFlags a uint32 enum class.

Revision Contents
Changeset List

PathSize
src/
21 lines

Diff 38550

View Options

src/net_permissions.h

Loading...