[Chronik] Require at least Protobuf 3.0.0 for Chronik functional tests
ClosedPublic
Actions

Authored by tobias_ruck on Mar 14 2023, 14:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCee83e416fb31: [Chronik] Require at least Protobuf 3.0.0 for Chronik functional tests

Summary

Chronik uses the proto3 syntax, which isn't supported in older protobuf compilers. proto3 was introduced in 3.0.0, so this is the minimal possible version.

Test Plan

cmake .. -GNinja -DBUILD_BITCOIN_CHRONIK=on

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-protobuf-check-version

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22444
Build 44513: Build Diff	build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 44512: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 14 2023, 14:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2023, 14:06

tobias_ruck requested review of this revision.Mar 14 2023, 14:06

tobias_ruck added a child revision: D13331: Replace spaces with tabs in test/CMakeLists.txt.Mar 14 2023, 14:14

Fabien requested changes to this revision.Mar 14 2023, 14:17

Fabien added inline comments.

test/CMakeLists.txt
60	There is a missed opportunity here. See src/qt/CMakeLists,txt: there is a check for protobuf > 3.1.0 that defines some preprocessor macro for compatibility reasons. We should rather consistently enforce 3.1.0 minimum version: Here In dependencies.md In src/qt/CMakeLists,txt And clean the compatibility branch alltogether.