Refactor: Changes remaining time variable type from int to chrono
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 15:23.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC32f920cff995: Refactor: Changes remaining time variable type from int to chrono

Summary

This is a partial backport of core#23832
https://github.com/bitcoin/bitcoin/pull/23832/commits/6111b0d7fac89b7a0a03284ca6ec030ca7f30b99

Depends on D13374

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22519
Build 44658: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 44657: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2023, 15:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 15:23

PiRK requested review of this revision.Mar 17 2023, 15:23

teamcity edited the summary of this revision. (Show Details)Mar 17 2023, 15:23

PiRK mentioned this in D13374: Change time variable type to std::chrono::seconds in src/net_processing.cpp.Mar 17 2023, 15:23

PiRK added a child revision: D13376: Refactor: Uses c++ init convention for time variables.Mar 17 2023, 15:25

Harbormaster completed remote builds in B22519: Diff 38673.Mar 17 2023, 15:39

sdulfari accepted this revision.Mar 17 2023, 20:04

This revision is now accepted and ready to land.Mar 17 2023, 20:04

Closed by commit rABC32f920cff995: Refactor: Changes remaining time variable type from int to chrono (authored by Shashwat <svangani239@gmail.com>, committed by PiRK). · Explain WhyMar 20 2023, 07:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC32f920cff995: Refactor: Changes remaining time variable type from int to chrono.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

38 lines

Diff 38673

View Options

Refactor: Changes remaining time variable type from int to chronoClosedPublicActions