[ecashaddrjs] Move linting to monorepo standard
ClosedPublic
Actions

Authored by bytesofman on Mar 17 2023, 23:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9e1a06d0d0e1: [ecashaddrjs] Move linting to monorepo standard

Summary

T2848

Depends on D13386

Remove package-specific linting as the repo is covered by arc lint. arc lint changes required to push the repo to the monorepo break the unit tests. This diff fixes them.

Test Plan

npm test and all pass

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-ecashaddrjs-to-monorepo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22535
Build 44690: Build Diff
Build 44689: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 17 2023, 23:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 23:13

bytesofman requested review of this revision.Mar 17 2023, 23:13

Harbormaster completed remote builds in B22535: Diff 38689.Mar 17 2023, 23:13

bytesofman added a child revision: D13388: [ecashaddrjs] Fixing dependency tree.Mar 17 2023, 23:31

See comment in D13386 regarding yarn.
I don't understand the summary about the unit tests, and I don't see any test change. Can you please elaborate ?

In D13387#298672, @Fabien wrote:

See comment in D13386 regarding yarn.
I don't understand the summary about the unit tests, and I don't see any test change. Can you please elaborate ?

from slack: