Page MenuHomePhabricator

[ecashaddrjs] Fixing dependency tree
ClosedPublic

Authored by bytesofman on Mar 17 2023, 23:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa382309f1e66: [ecashaddrjs] Fixing dependency tree
Summary

T2848

Depends on D13387

npm audit brought up a number of moderate to severe issues. Resolved with a combination of

  • npm audit fix
  • individually updating dev dependencies to latest version
  • removing coveralls and its associated .yaml file, which had no fix, no new version in 2 years, not used here
  • Update unit tests to use updated syntax of latest random-js version
Test Plan

npm audit and all good
npm test and unit tests pass
npm run build and no build errors

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22672
Build 44964: Build Diff
Build 44963: arc lint + arc unit

Event Timeline

The changes lgtm but needs this will need a rebase after you addressed the comments in the dependencies

This revision is now accepted and ready to land.Mar 25 2023, 13:05
This revision was automatically updated to reflect the committed changes.