Page MenuHomePhabricator
Differential D13400

Prevent copies in mempool_tests
ClosedPublic
Actions

Authored by Fabien on Mar 21 2023, 10:07.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC86ef87cee1f8: Prevent copies in mempool_tests
Summary

We can hold a const reference instead as the entries are read only.

Test Plan
ninja check-bitcoin-mempool_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 21 2023, 10:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2023, 10:07
Fabien requested review of this revision.Mar 21 2023, 10:07
Harbormaster completed remote builds in B22564: Diff 38731.Mar 21 2023, 10:28
PiRK accepted this revision.Mar 21 2023, 13:36
This revision is now accepted and ready to land.Mar 21 2023, 13:36
Closed by commit rABC86ef87cee1f8: Prevent copies in mempool_tests (authored by Fabien). · Explain WhyMar 21 2023, 14:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC86ef87cee1f8: Prevent copies in mempool_tests.

Revision Contents
Changeset List

PathSize
src/
test/
7 lines

Diff 38734

View Options

src/test/mempool_tests.cpp

Loading...