Page MenuHomePhabricator
Differential D13458

[Chronik] Add `TxId` to bitcoinsuite-core
ClosedPublic
Actions

Authored by tobias_ruck on Mar 24 2023, 14:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbd7a6d28fb1d: [Chronik] Add `TxId` to bitcoinsuite-core
Summary

Similar to BlockHash, but for TxId. We keep the implementation of both separate so they can't refer to the same type.

Test Plan

ninja check-crates

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-txid
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixchronik/bitcoinsuite-core/src/tx/txid.rs:42WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 22662
Build 44944: Build Diffbuild-chronik
Build 44943: arc lint + arc unit

Event Timeline

tobias_ruck requested review of this revision.Mar 24 2023, 14:10
tobias_ruck updated this revision to Diff 38845.
tobias_ruck created this revision.

trailing whitespace

Harbormaster completed remote builds in B22663: Diff 38845.Mar 24 2023, 14:27
Harbormaster completed remote builds in B22662: Diff 38844.
tobias_ruck added a child revision: D13437: [Chronik] Add `TxReader` and `TxWriter`.Mar 24 2023, 14:31
Fabien accepted this revision.Mar 24 2023, 15:10
This revision is now accepted and ready to land.Mar 24 2023, 15:10
Closed by commit rABCbd7a6d28fb1d: [Chronik] Add `TxId` to bitcoinsuite-core (authored by tobias_ruck). · Explain WhyMar 24 2023, 16:36
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCbd7a6d28fb1d: [Chronik] Add `TxId` to bitcoinsuite-core.

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-core/
src/
1 line
tx/
8 lines
171 lines

Diff 38844

View Options

chronik/bitcoinsuite-core/src/lib.rs

Loading...
View Options

chronik/bitcoinsuite-core/src/tx/mod.rs

Loading...
View Options

chronik/bitcoinsuite-core/src/tx/txid.rs

Loading...