Page MenuHomePhabricator
Differential D13464

[Chronik] Add `load_tx`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 25 2023, 10:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC926e72bc1451: [Chronik] Add `load_tx`
Summary

Load transactions from the disk using file_num, data_pos and undo_pos, which we already indexed.

Allows us to read txs from the node when requested by the user.

Depends on D13428.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t bridgeprimitives_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck requested review of this revision.Mar 25 2023, 10:16
tobias_ruck created this revision.
Harbormaster completed remote builds in B22694: Diff 38879.Mar 25 2023, 10:31
tobias_ruck updated this revision to Diff 38881.Mar 25 2023, 10:45

rebase on chronik-bridge-txs

tobias_ruck edited the summary of this revision. (Show Details)Mar 25 2023, 10:45
tobias_ruck added a parent revision: D13428: [Chronik] Bridge txs in `bridge_block`.
Harbormaster completed remote builds in B22696: Diff 38881.Mar 25 2023, 11:02
tobias_ruck added a comment.Mar 25 2023, 11:40

should this be load_tx_from_disk?

Fabien accepted this revision.Mar 25 2023, 12:55
Fabien added inline comments.
chronik/chronik-cpp/chronik_bridge.cpp
232 ↗(On Diff #38881)
This revision is now accepted and ready to land.Mar 25 2023, 12:55
tobias_ruck updated this revision to Diff 38883.Mar 25 2023, 13:19

std::move

Harbormaster completed remote builds in B22697: Diff 38883.Mar 25 2023, 13:37
Closed by commit rABC926e72bc1451: [Chronik] Add `load_tx` (authored by tobias_ruck). · Explain WhyMar 25 2023, 13:46
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC926e72bc1451: [Chronik] Add `load_tx`.

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
4 lines
chronik-cpp/
3 lines
16 lines
test/
49 lines

Diff 38888

View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/test/bridgeprimitives_tests.cpp

Loading...