Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa7e11896dc65: [Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs

Summary

We store everything we need to index the mempool in the Mempool struct.

Currently, we redundantly store all the mempool txs again, but this reduces implementation complexity. Once RAM usage becomes an issue, we can make sure we re-use the node's mempool.

To get a mempool tx, we add bridge_tx, which finds the spent coins for us and builds a ffi::Tx.

make_chronik_block now sets the time_first_seen of the mempool.

Depends on D13467.

Test Plan

ninja check-crates && ninja && ./test/functional/test_runner.py chronik_tx

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 25 2023, 23:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2023, 23:20

tobias_ruck requested review of this revision.Mar 25 2023, 23:20

tobias_ruck edited the summary of this revision. (Show Details)Mar 25 2023, 23:21

tobias_ruck added a parent revision: D13467: [Chronik] Index txs; add `/tx/:txid` HTTP endpoint.

Harbormaster completed remote builds in B22706: Diff 38900.Mar 25 2023, 23:37

Fabien added inline comments.Mar 26 2023, 19:17

chronik/chronik-cpp/chronik_validationinterface.cpp
35 ↗	(On Diff #38900)	You can just pass `info` here
chronik/chronik-lib/src/bridge.rs
126 ↗	(On Diff #38900)	what happens if bridge_tx throws ?

Add test whether conflicted tx actually gets removed from mempool

Harbormaster completed remote builds in B22715: Diff 38911.Mar 27 2023, 10:14

Rebase on chronik-tx

Harbormaster completed remote builds in B22717: Diff 38913.Mar 27 2023, 10:42

Fabien accepted this revision.Mar 27 2023, 14:42

This revision is now accepted and ready to land.Mar 27 2023, 14:42

Rebase from chronik-tx

Harbormaster completed remote builds in B22735: Diff 38932.Mar 27 2023, 16:19

Closed by commit rABCa7e11896dc65: [Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs (authored by tobias_ruck). · Explain WhyMar 27 2023, 17:33

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCa7e11896dc65: [Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs.

[Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38944

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-cpp/chronik_bridge.h

chronik/chronik-cpp/chronik_bridge.cpp

chronik/chronik-cpp/chronik_validationinterface.h

chronik/chronik-cpp/chronik_validationinterface.cpp

chronik/chronik-indexer/src/indexer.rs

chronik/chronik-indexer/src/lib.rs

chronik/chronik-indexer/src/mempool.rs

chronik/chronik-indexer/src/query/txs.rs

chronik/chronik-lib/src/bridge.rs

chronik/chronik-lib/src/ffi.rs

test/functional/chronik_tx.py

[Chronik] Add `Mempool`, make `/tx/:txid` return mempool txsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38944

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-cpp/chronik_bridge.h

chronik/chronik-cpp/chronik_bridge.cpp

chronik/chronik-cpp/chronik_validationinterface.h

chronik/chronik-cpp/chronik_validationinterface.cpp

chronik/chronik-indexer/src/indexer.rs

chronik/chronik-indexer/src/lib.rs

chronik/chronik-indexer/src/mempool.rs

chronik/chronik-indexer/src/query/txs.rs

chronik/chronik-lib/src/bridge.rs

chronik/chronik-lib/src/ffi.rs

test/functional/chronik_tx.py

[Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs
ClosedPublic
Actions

Revision Contents
Changeset List