Page MenuHomePhabricator

[ecashaddrjs] Use ecash: addresses in unit tests
ClosedPublic

Authored by bytesofman on Mar 27 2023, 12:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1570a7526299: [ecashaddrjs] Use ecash: addresses in unit tests
Summary

T3039

Convert address formats from bitcoincash: to ecash: for unit tests of cashaddr.js

Note: One bitcoincash: adddress remains, as it was manually constructed to have an improper version byte. updated to ecash: version

Test Plan

npm test and still pass

Diff Detail

Repository
rABC Bitcoin ABC
Branch
path-to-publish-ecashaddrjs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22721
Build 45062: Build Diff
Build 45061: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Mar 27 2023, 15:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecashaddrjs/test/cashaddr.js
137

ecash:zpm2qsznhks23z7629mms6s4cwef74vcwv6ddac6re

This revision now requires changes to proceed.Mar 27 2023, 15:17

replacing version byte error test with ecash: address

This revision is now accepted and ready to land.Mar 27 2023, 16:11