Page MenuHomePhabricator
Differential D13475

[ecashaddrjs] Support decoding prefixless addresses if checksum is correct
ClosedPublic
Actions

Authored by bytesofman on Mar 27 2023, 12:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe41a1ff040a9: [ecashaddrjs] Support decoding prefixless addresses if checksum is correct
Summary

T3039

Depends on D13474

Test Plan

Review change to function and new unit test. npm test and all pass.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22729
Build 45078: Build Diff
Build 45077: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 27 2023, 12:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2023, 12:56
bytesofman requested review of this revision.Mar 27 2023, 12:56
Harbormaster completed remote builds in B22722: Diff 38918.Mar 27 2023, 12:56
bytesofman added a child revision: D13476: [ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js.Mar 27 2023, 13:02
Fabien accepted this revision.Mar 27 2023, 15:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecashaddrjs/src/cashaddr.js
88 ↗(On Diff #38918)

Nit: you could also print the list of supported prefixes and hint to not use a prefixless address if the prefix is not in this list

This revision is now accepted and ready to land.Mar 27 2023, 15:26
bytesofman updated this revision to Diff 38926.Mar 27 2023, 15:49

Print list of valid prefixes on prefixless error

Harbormaster completed remote builds in B22729: Diff 38926.Mar 27 2023, 15:50
Closed by commit rABCe41a1ff040a9: [ecashaddrjs] Support decoding prefixless addresses if checksum is correct (authored by bytesofman). · Explain WhyMar 27 2023, 16:23
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCe41a1ff040a9: [ecashaddrjs] Support decoding prefixless addresses if checksum is correct.

Revision Contents
Changeset List

PathSize
web/
ecashaddrjs/
src/
40 lines
test/
26 lines

Diff 38926

View Options

web/ecashaddrjs/src/cashaddr.js

Loading...
View Options

web/ecashaddrjs/test/cashaddr.js

Loading...