Page MenuHomePhabricator

Use block policy state instead of parked state to determine if a policy was violated
ClosedPublic

Authored by sdulfari on Mar 27 2023, 21:14.

Details

Summary

Bubble the block policy state up through ConnectTip so the caller can more
robustly short circuit when a block policy fails (and not just assume that
a policy failed because a block was parked).

Depends on D13482

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

This revision is now accepted and ready to land.Mar 28 2023, 09:27
Fabien added inline comments.
src/validation.cpp
2733

See question in D13482: does std::all_of stop on first false condition (and is that guaranteed) ? Otherwise the design is wrong