Page MenuHomePhabricator

[alias-server] deprecate return of pending alias txs from getValidAliasRegistrations function
ClosedPublic

Authored by bytesofman on Mar 31 2023, 12:15.

Details

Summary

T3060

Depends on D13518

It doesn't make sense to get pending (i.e. unconfirmed but otherwise valid) alias registrations in a function that will be called when new blocks are found. Pending alias txs will be handled separately.

Test Plan

npm test
node index.js and app works as normal

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22867
Build 45354: Build Diffalias-server-tests
Build 45353: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Mar 31 2023, 12:49
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/scripts/generateMocks.js
9

this should be require('../src/alias');, otherwise the following error is throw when running npm run mocks

image.png (419×891 px, 80 KB)

This revision now requires changes to proceed.Mar 31 2023, 12:49

just saw this issue is rectified in D13520

This revision is now accepted and ready to land.Mar 31 2023, 12:54