Page MenuHomePhabricator
Differential D13534

[Chronik] Add `compress_script` and `decompress_script` to `chronik-bridge` FFI
ClosedPublic
Actions

Authored by tobias_ruck on Apr 2 2023, 23:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC00941a587064: [Chronik] Add `compress_script` and `decompress_script` to `chronik-bridge` FFI
Summary

Used to reduce the size of scripts in the DB. We re-use the existing compression from the node.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t bridgecompression_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Apr 2 2023, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2023, 23:43
tobias_ruck requested review of this revision.Apr 2 2023, 23:43
Harbormaster completed remote builds in B22895: Diff 39136.Apr 3 2023, 00:00
Fabien requested changes to this revision.Apr 3 2023, 10:27
Fabien added inline comments.
chronik/test/bridgecompression_tests.cpp
10 ↗(On Diff #39136)
18 ↗(On Diff #39136)

I appreciate the effort but I think it's not a good idea to check against the compressed hex. This is implementation dependent and makes the test obsolete if the compressor algorithm changes, or chronik picks another compression method.

What you want from a compressor is the make sure compressed.size() <= original.size() and the data is recovered after a roundtrip.

This revision now requires changes to proceed.Apr 3 2023, 10:27
tobias_ruck updated this revision to Diff 39151.Apr 3 2023, 13:11

Remove compressed hex in tests

Harbormaster completed remote builds in B22905: Diff 39151.Apr 3 2023, 13:40
Fabien accepted this revision.Apr 3 2023, 15:54
This revision is now accepted and ready to land.Apr 3 2023, 15:54
Closed by commit rABC00941a587064: [Chronik] Add `compress_script` and `decompress_script` to `chronik-bridge` FFI (authored by tobias_ruck). · Explain WhyApr 3 2023, 17:12
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC00941a587064: [Chronik] Add `compress_script` and `decompress_script` to `chronik-bridge` FFI.

Revision Contents
Changeset List

PathSize
chronik/
chronik-bridge/
src/
6 lines
chronik-cpp/
4 lines
18 lines
util/
7 lines
test/
58 lines
src/
test/
3 lines

Diff 39173

View Options

chronik/chronik-bridge/src/ffi.rs

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/chronik-cpp/util/collection.h

Loading...
View Options

chronik/test/bridgecompression_tests.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...