Paths

Table of Contentst

Differential D13539

` bound on `Group::Member`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 3 2023, 13:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC201a7ecbbbe2: [Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group…

Summary

This makes the code cleaner (no newtyping necessary to get custom serialization), and more flexible (groups can use &self) when serializing.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Apr 3 2023, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2023, 13:23

tobias_ruck requested review of this revision.Apr 3 2023, 13:23

tobias_ruck mentioned this in D13535: [Chronik] Add `/script/:type/:payload/history`.Apr 3 2023, 13:27

Harbormaster completed remote builds in B22906: Diff 39152.Apr 3 2023, 13:42

Fabien accepted this revision.Apr 3 2023, 15:56

This revision is now accepted and ready to land.Apr 3 2023, 15:56

Closed by commit rABC201a7ecbbbe2: [Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group… (authored by tobias_ruck). · Explain WhyApr 3 2023, 17:13

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC201a7ecbbbe2: [Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group….

Revision Contents
Changeset List

Path

Size

chronik/

chronik-db/

src/

group.rs

5 lines

io/

group_history.rs

4 lines

mem/

group_history.rs

4 lines

test/

value_group.rs

12 lines

Diff 39174

View Options

chronik/chronik-db/src/group.rs

View Options

chronik/chronik-db/src/io/group_history.rs

View Options

chronik/chronik-db/src/mem/group_history.rs

View Options

chronik/chronik-db/src/test/value_group.rs

[Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group::Member`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39174

chronik/chronik-db/src/group.rs

chronik/chronik-db/src/io/group_history.rs

chronik/chronik-db/src/mem/group_history.rs

chronik/chronik-db/src/test/value_group.rs

[Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group::Member`
ClosedPublic
Actions

Revision Contents
Changeset List