Page MenuHomePhabricator
Differential D13542

[depends] Force PIC/PIE in native protobuf
ClosedPublic
Actions

Authored by Fabien on Apr 3 2023, 14:28.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1de41a13e42b: [depends] Force PIC/PIE in native protobuf
Summary

The cmake build for protobuf is expected to set it automatically if the shared builds are not built, but it appears to not always be the case depending on the host (e.g. guix).

Test Plan

Run the linux gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
native_protobuf_force_pie
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22916
Build 45452: Build Diff
Build 45451: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 3 2023, 14:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2023, 14:28
Fabien requested review of this revision.Apr 3 2023, 14:28
Harbormaster completed remote builds in B22916: Diff 39162.Apr 3 2023, 14:29
PiRK accepted this revision.Apr 3 2023, 15:15
PiRK added a subscriber: PiRK.

I thought I tried that.

This revision is now accepted and ready to land.Apr 3 2023, 15:15
Closed by commit rABC1de41a13e42b: [depends] Force PIC/PIE in native protobuf (authored by Fabien). · Explain WhyApr 3 2023, 15:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1de41a13e42b: [depends] Force PIC/PIE in native protobuf.

Revision Contents
Changeset List

PathSize
depends/
packages/
1 line

Diff 39162

View Options

depends/packages/native_protobuf.mk

Loading...