Page MenuHomePhabricator
Differential D13546

[ecashaddrjs] linting with eslint
ClosedPublic
Actions

Authored by bytesofman on Apr 3 2023, 21:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC310011482649: [ecashaddrjs] linting with eslint
Summary

T3044

To bring ecashaddrjs into arc lint, first lint the repo with eslint

Test Plan

Confirm changes are linting errors
eslint . from web/ecashaddrjs/ and no output

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashaddr-ci
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22930
Build 45480: Build Diff
Build 45479: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 3 2023, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2023, 21:41
bytesofman requested review of this revision.Apr 3 2023, 21:41
Harbormaster completed remote builds in B22929: Diff 39186.Apr 3 2023, 21:41
bytesofman updated this revision to Diff 39187.Apr 3 2023, 21:43

newline, move use strict to below header in test files

Harbormaster completed remote builds in B22930: Diff 39187.Apr 3 2023, 21:43
bytesofman added a child revision: D13547: [ecashaddrjs] Adding to arc lint.Apr 3 2023, 21:46
Fabien accepted this revision.Apr 4 2023, 08:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecashaddrjs/.eslintignore
2

This file shouldn't be needed if these entries are in the .gitignore, as arcanist will not pass any file that is not tracked to the linter

This revision is now accepted and ready to land.Apr 4 2023, 08:22
Fabien mentioned this in D13547: [ecashaddrjs] Adding to arc lint.Apr 4 2023, 08:23
Closed by commit rABC310011482649: [ecashaddrjs] linting with eslint (authored by bytesofman). · Explain WhyApr 4 2023, 09:43
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC310011482649: [ecashaddrjs] linting with eslint.

Revision Contents
Changeset List

PathSize
web/
ecashaddrjs/
2 lines
16 lines
1272 lines
1 line
test/
3 lines
3 lines
3 lines
2 lines

Diff 39187

View Options

web/ecashaddrjs/.eslintignore

Loading...
View Options

web/ecashaddrjs/.eslintrc.js

Loading...
View Options

web/ecashaddrjs/package-lock.json

Loading...
View Options

web/ecashaddrjs/package.json

Loading...
View Options

web/ecashaddrjs/test/base32.js

Loading...
View Options

web/ecashaddrjs/test/cashaddr.js

Loading...
View Options

web/ecashaddrjs/test/convertBits.js

Loading...
View Options

web/ecashaddrjs/webpack.config.js

Loading...