[alias-server] Initialize telegram bot in index.js and pass as function parameter to websocket functions
ClosedPublic
Actions

Authored by bytesofman on Apr 4 2023, 10:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC232f39346586: [alias-server] Initialize telegram bot in index.js and pass as function…

Summary

T3060

Initializing the telegram bot creates a polling telegram bot. If this is done in any unit tests, the unit test will hang indefinitely and not resolve.

Initialize the telegram bot from index.js on app startup and pass as a param. In this way, you can mock it for unit tests, or create unit tests that do not depend on the telegram bot.

Test Plan

Confirm no lint errors related to parameter redefinition
node index.js and nothing breaks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alias-server-move-tg-initialization

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22949
Build 45518: Build Diff	alias-server-tests
Build 45517: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 4 2023, 10:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2023, 10:38

bytesofman requested review of this revision.Apr 4 2023, 10:38

Harbormaster completed remote builds in B22949: Diff 39215.Apr 4 2023, 11:08

Fabien accepted this revision.Apr 4 2023, 14:06

Fabien retitled this revision from [alias-server] Initialize telegram bot in index.js and pass as function paramater to websocket functions to [alias-server] Initialize telegram bot in index.js and pass as function parameter to websocket functions.

This revision is now accepted and ready to land.Apr 4 2023, 14:07

bytesofman mentioned this in D13523: [alias-server] Check if chaintip is finalized by avalanche before adding new aliases.Apr 4 2023, 15:12

Closed by commit rABC232f39346586: [alias-server] Initialize telegram bot in index.js and pass as function… (authored by bytesofman). · Explain WhyApr 4 2023, 15:19

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC232f39346586: [alias-server] Initialize telegram bot in index.js and pass as function….