[lint] don't add newline to empty python files
ClosedPublic
Actions

Authored by PiRK on Apr 6 2023, 11:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC97b52f90be23: [lint] don't add newline to empty python files

Summary

It can make sense to have an empty __init__.py in a python subpackage. An empty file does not need f-strings, so return early.

Test Plan

Run arc lint --everything and check that test/functional/test_framework/__init__.py is untouched

Diff Detail

Repository

rABC Bitcoin ABC

Branch

no_newline_empty_file

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23026
Build 45672: Build Diff
Build 45671: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 6 2023, 11:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 11:04

PiRK requested review of this revision.Apr 6 2023, 11:04

Harbormaster completed remote builds in B23026: Diff 39332.Apr 6 2023, 11:04

Fabien accepted this revision.Apr 6 2023, 11:19

This revision is now accepted and ready to land.Apr 6 2023, 11:19

Closed by commit rABC97b52f90be23: [lint] don't add newline to empty python files (authored by PiRK). · Explain WhyApr 6 2023, 12:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC97b52f90be23: [lint] don't add newline to empty python files.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

FlyntLinter.php

2 lines

Diff 39332

View Options

arcanist/linter/FlyntLinter.php

[lint] don't add newline to empty python filesClosedPublicActions