Page MenuHomePhabricator

devtools: Improve *-check.py tool detection
ClosedPublic

Authored by PiRK on Apr 7 2023, 07:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3494bc952008: devtools: Improve *-check.py tool detection
Summary

This is important to make sure that we're not testing tools different from the one we're building with.

Introduce determine_wellknown_cmd, which encapsulates how we should handle well-known tools specification (IFS splitting, env override, etc.).

This is a partial backport of core#22381
https://github.com/bitcoin/bitcoin/pull/22381/commits/9fdc8afe117b7b1ea845f8acae9e831922b8f92b

Test Plan

gitian builds

Diff Detail

Event Timeline

@bot gitian-win gitian-linux gitian-osx

Tail of the build log:

-- Performing Test have_CXX__Wno_inconsistent_missing_override
-- Performing Test have_CXX__Wno_inconsistent_missing_override - Success
-- Performing Test have_CXX__Wno_maybe_uninitialized
-- Performing Test have_CXX__Wno_maybe_uninitialized - Failed
-- Performing Test have_CXX__Wno_shadow
-- Performing Test have_CXX__Wno_shadow - Success
-- Performing Test have_CXX__Wno_sign_compare
-- Performing Test have_CXX__Wno_sign_compare - Success
-- Performing Test have_CXX__Wno_unused_const_variable
-- Performing Test have_CXX__Wno_unused_const_variable - Success
-- Performing Test have_CXX__Wno_conditional_uninitialized
-- Performing Test have_CXX__Wno_conditional_uninitialized - Success
-- Performing Test have_C__Wno_strict_prototypes
-- Performing Test have_C__Wno_strict_prototypes - Success
-- Looking for C++ include atomic
-- Looking for C++ include atomic - found
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Failed
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found Event component event: /usr/lib/x86_64-linux-gnu/libevent.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: event 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: filesystem 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: thread 
-- Found Event component pthreads: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: pthreads 
-- Found MiniUPnPc component miniupnpc: /usr/lib/x86_64-linux-gnu/libminiupnpc.so
-- Found MiniUPnPc: /usr/include/miniupnpc (found suitable version "2.2.1", minimum required is "1.9")  
-- Found NATPMP component natpmp: /usr/lib/x86_64-linux-gnu/libnatpmp.so
-- Found NATPMP: /usr/include   
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: unit_test_framework 
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK - Success
-- Found BerkeleyDB component CXX: /usr/lib/x86_64-linux-gnu/libdb_cxx-5.3.so
-- Found BerkeleyDB: /usr/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX 
-- Found SQLite3: /usr/include (found suitable version "3.34.1", minimum required is "3.7.17") 
CMake Error at cmake/modules/BinaryTest.cmake:9 (find_program_or_fail):
  Unknown CMake command "find_program_or_fail".
Call Stack (most recent call first):
  src/CMakeLists.txt:716 (add_to_symbols_check)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-clang/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-clang/CMakeFiles/CMakeError.log".
Build build-clang failed with exit code 1

Tail of the build log:

-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
CMake Error at cmake/modules/BinaryTest.cmake:9 (find_program_or_fail):
  Unknown CMake command "find_program_or_fail".
Call Stack (most recent call first):
  src/seeder/CMakeLists.txt:21 (add_to_symbols_check)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-clang-tidy/native/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-clang-tidy/native/CMakeFiles/CMakeError.log".
ninja: error: loading 'build.ninja': No such file or directory
Traceback (most recent call last):
  File "/work/cmake/utils/gen-ninja-deps.py", line 44, in <module>
    for t in subprocess.check_output([ninja, '-t', 'targets', 'all']).splitlines():
  File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/ninja', '-t', 'targets', 'all']' returned non-zero exit status 1.
[108/536] Generating bitcoin_hu.qm
Removed plural forms as the target language has less forms.
If this sounds wrong, possibly the target language is not set or recognized.
[125/536] Generating bitcoin_pl.qm
Removed plural forms as the target language has less forms.
If this sounds wrong, possibly the target language is not set or recognized.
[137/536] Generating bitcoin_ru.qm
Removed plural forms as the target language has less forms.
If this sounds wrong, possibly the target language is not set or recognized.
[147/536] Generating bitcoin_tr.qm
Removed plural forms as the target language has less forms.
If this sounds wrong, possibly the target language is not set or recognized.
[205/536] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
FAILED: native/CMakeCache.txt 
cd /work/abc-ci-builds/build-clang-tidy && /work/abc-ci-builds/build-clang-tidy/config/run_native_cmake.sh
[207/536] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[208/536] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[209/536] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[210/536] Linking CXX static library src/libutil.a
[211/536] Linking CXX static library src/librpcclient.a
[212/536] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[213/536] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[214/536] Linking CXX static library src/zmq/libzmq.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Tail of the build log:

-- Performing Test have_CXX__Wno_maybe_uninitialized
-- Performing Test have_CXX__Wno_maybe_uninitialized - Success
-- Performing Test have_CXX__Wno_shadow
-- Performing Test have_CXX__Wno_shadow - Success
-- Performing Test have_CXX__Wno_sign_compare
-- Performing Test have_CXX__Wno_sign_compare - Success
-- Performing Test have_CXX__Wno_unused_const_variable
-- Performing Test have_CXX__Wno_unused_const_variable - Success
-- Performing Test have_CXX__Wno_conditional_uninitialized
-- Performing Test have_CXX__Wno_conditional_uninitialized - Success
-- Performing Test have_C__Wno_strict_prototypes
-- Performing Test have_C__Wno_strict_prototypes - Success
-- Looking for C++ include atomic
-- Looking for C++ include atomic - found
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found Event component event: /usr/lib/x86_64-linux-gnu/libevent.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: event 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: filesystem 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: thread 
-- Found Event component pthreads: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: pthreads 
-- Found MiniUPnPc component miniupnpc: /usr/lib/x86_64-linux-gnu/libminiupnpc.so
-- Found MiniUPnPc: /usr/include/miniupnpc (found suitable version "2.2.1", minimum required is "1.9")  
-- Found NATPMP component natpmp: /usr/lib/x86_64-linux-gnu/libnatpmp.so
-- Found NATPMP: /usr/include   
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: unit_test_framework 
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK - Success
-- Found BerkeleyDB component CXX: /usr/lib/x86_64-linux-gnu/libdb_cxx-5.3.so
-- Found BerkeleyDB: /usr/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX 
-- Found SQLite3: /usr/include (found suitable version "3.34.1", minimum required is "3.7.17") 
CMake Error at cmake/modules/BinaryTest.cmake:9 (find_program_or_fail):
  Unknown CMake command "find_program_or_fail".
Call Stack (most recent call first):
  src/CMakeLists.txt:716 (add_to_symbols_check)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-debug/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-debug/CMakeFiles/CMakeError.log".
Build build-debug failed with exit code 1

Tail of the build log:

-- Performing Test have_CXX__Wno_maybe_uninitialized
-- Performing Test have_CXX__Wno_maybe_uninitialized - Success
-- Performing Test have_CXX__Wno_shadow
-- Performing Test have_CXX__Wno_shadow - Success
-- Performing Test have_CXX__Wno_sign_compare
-- Performing Test have_CXX__Wno_sign_compare - Success
-- Performing Test have_CXX__Wno_unused_const_variable
-- Performing Test have_CXX__Wno_unused_const_variable - Success
-- Performing Test have_CXX__Wno_conditional_uninitialized
-- Performing Test have_CXX__Wno_conditional_uninitialized - Success
-- Performing Test have_C__Wno_strict_prototypes
-- Performing Test have_C__Wno_strict_prototypes - Success
-- Looking for C++ include atomic
-- Looking for C++ include atomic - found
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found Event component event: /usr/lib/x86_64-linux-gnu/libevent.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: event 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: filesystem 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: thread 
-- Found Event component pthreads: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: pthreads 
-- Found MiniUPnPc component miniupnpc: /usr/lib/x86_64-linux-gnu/libminiupnpc.so
-- Found MiniUPnPc: /usr/include/miniupnpc (found suitable version "2.2.1", minimum required is "1.9")  
-- Found NATPMP component natpmp: /usr/lib/x86_64-linux-gnu/libnatpmp.so
-- Found NATPMP: /usr/include   
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: unit_test_framework 
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK - Success
-- Found BerkeleyDB component CXX: /usr/lib/x86_64-linux-gnu/libdb_cxx-5.3.so
-- Found BerkeleyDB: /usr/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX 
-- Found SQLite3: /usr/include (found suitable version "3.34.1", minimum required is "3.7.17") 
CMake Error at cmake/modules/BinaryTest.cmake:9 (find_program_or_fail):
  Unknown CMake command "find_program_or_fail".
Call Stack (most recent call first):
  src/CMakeLists.txt:716 (add_to_symbols_check)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-diff/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-diff/CMakeFiles/CMakeError.log".
Build build-diff failed with exit code 1

Tail of the build log:

-- Performing Test have_CXX__Wno_inconsistent_missing_override - Success
-- Performing Test have_CXX__Wno_maybe_uninitialized
-- Performing Test have_CXX__Wno_maybe_uninitialized - Success
-- Performing Test have_CXX__Wno_shadow
-- Performing Test have_CXX__Wno_shadow - Success
-- Performing Test have_CXX__Wno_sign_compare
-- Performing Test have_CXX__Wno_sign_compare - Success
-- Performing Test have_CXX__Wno_unused_const_variable
-- Performing Test have_CXX__Wno_unused_const_variable - Success
-- Performing Test have_CXX__Wno_conditional_uninitialized
-- Performing Test have_CXX__Wno_conditional_uninitialized - Success
-- Performing Test have_C__Wno_strict_prototypes
-- Performing Test have_C__Wno_strict_prototypes - Success
-- Looking for C++ include atomic
-- Looking for C++ include atomic - found
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found Event component event: /usr/lib/x86_64-linux-gnu/libevent.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: event 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: filesystem 
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: thread 
-- Found Event component pthreads: /usr/lib/x86_64-linux-gnu/libevent_pthreads.so
-- Found Event: /usr/include (found suitable version "2.1.12-stable", minimum required is "2.0.22") found components: pthreads 
-- Found MiniUPnPc component miniupnpc: /usr/lib/x86_64-linux-gnu/libminiupnpc.so
-- Found MiniUPnPc: /usr/include/miniupnpc (found suitable version "2.2.1", minimum required is "1.9")  
-- Found NATPMP component natpmp: /usr/lib/x86_64-linux-gnu/libnatpmp.so
-- Found NATPMP: /usr/include   
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.59") found components: unit_test_framework 
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK
-- Performing Test BOOST_REQUIRES_TEST_DYN_LINK - Success
-- Found ZeroMQ component zmq: /usr/lib/x86_64-linux-gnu/libzmq.so
-- Found ZeroMQ: /usr/include (found suitable version "4.3.4", minimum required is "4.1.5")  
CMake Error at cmake/modules/BinaryTest.cmake:9 (find_program_or_fail):
  Unknown CMake command "find_program_or_fail".
Call Stack (most recent call first):
  src/seeder/CMakeLists.txt:21 (add_to_symbols_check)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-without-wallet/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-without-wallet/CMakeFiles/CMakeError.log".
Build build-without-wallet failed with exit code 1

Tail of the build log:

[07:48:54] :	 [Step 1/1]  * [new tag]             phabricator/diff/39372 -> phabricator/diff/39372
[07:48:54] :	 [Step 1/1]  * [new tag]             phabricator/diff/39384 -> phabricator/diff/39384
[07:48:54] :	 [Step 1/1]  * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
[07:48:54] :	 [Step 1/1]  * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
[07:48:54] :	 [Step 1/1]  * [new branch]          master                 -> master
[07:48:54] :	 [Step 1/1] --- Building for bullseye amd64 ---
[07:48:54] :	 [Step 1/1] Stopping target if it is up
[07:48:54] :	 [Step 1/1] Error response from daemon: No such container: gitian-target
[07:48:54] :	 [Step 1/1] Error: No such container: gitian-target
[07:48:54] :	 [Step 1/1] Making a new image copy
[07:48:54] :	 [Step 1/1] Starting target
[07:48:54] :	 [Step 1/1] Checking if target is up.
[07:48:54] :	 [Step 1/1] Preparing build environment
[07:48:54] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[07:48:54] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[07:48:54] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[07:48:54] :	 [Step 1/1] Creating package manifest
[07:48:54] :	 [Step 1/1] Creating build script (var/build-script)
[07:48:54] :	 [Step 1/1] Running build script (log in var/build.log)
[07:48:54] :	 [Step 1/1] ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:185:in `build_one_configuration'
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:339:in `block (2 levels) in <main>'
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:334:in `each'
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:334:in `block in <main>'
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:332:in `each'
[07:48:54] :	 [Step 1/1] 	from ./bin/gbuild:332:in `<main>'
[07:48:54] :	 [Step 1/1] Build gitian-osx failed with exit code 1
[07:48:54] :	 [Step 1/1] ~/infra ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:48:54]W:	 [Step 1/1] + RESULT=1
[07:48:54]W:	 [Step 1/1] + pushd /home/teamcity/infra
[07:48:54]W:	 [Step 1/1] + docker-compose stop apt-cache-proxy
[07:48:54]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ... 
[07:49:05] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:49:05]W:	 [Step 1/1]  [1A [2K
[07:49:05]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ...  [32mdone [0m
[07:49:05]W:	 [Step 1/1]  [1B+ popd
[07:49:05]W:	 [Step 1/1] + exit 1
[07:49:05]W:	 [Step 1/1] Process exited with code 1
[07:49:05]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[07:49:05] :	 [Step 1/1] Waiting for 1 service processes to complete
[07:49:05]E:	 [Step 1/1] Ant JUnit report watcher
[07:49:05]E:		 [Ant JUnit report watcher] No reports found for paths:
[07:49:05]E:		 [Ant JUnit report watcher] /home/teamcity/buildAgent/work/jailed-build/results/artifacts/junit/*.xml
[07:49:05]E:	 [Step 1/1] Step Command Line failed
[07:49:06]E: Ant JUnit report watcher
[07:49:06]E:	 [Ant JUnit report watcher] No reports found for paths:
[07:49:06]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[07:49:06]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[07:49:06] : Publishing internal artifacts (3s)
[07:49:08] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[07:49:08] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[07:49:06]W: Publishing artifacts (5s)
[07:49:06] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml, +:bitcoin-abc/abc-ci-builds/gitian-osx/gitian-results => gitian-osx.tar.gz]
[07:49:06]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[07:49:06] :	 [Publishing artifacts] Creating archive gitian-osx.tar.gz
[07:49:06] :		 [Creating archive gitian-osx.tar.gz] Creating /home/teamcity/buildAgent/temp/buildTmp/TarPreprocessor1226802552928520218/gitian-osx.tar.gz
[07:49:06] :		 [Creating archive gitian-osx.tar.gz] Archive was created, file size 204.34 KB (209253 bytes)
[07:49:10] :	 [Publishing artifacts] Publishing 1 file using [ArtifactsCachePublisher]: bitcoin-abc/abc-ci-builds/gitian-osx/gitian-results => gitian-osx.tar.gz
[07:49:10] :	 [Publishing artifacts] Publishing 1 file using [WebPublisher]: bitcoin-abc/abc-ci-builds/gitian-osx/gitian-results => gitian-osx.tar.gz
[07:49:11] : Build finished

Tail of the build log:

[07:55:05]E:	 [Step 1/1] Build gitian-win failed with exit code 1
[07:55:01]i:	 [Step 1/1] ##teamcity[buildProblem timestamp='2023-04-07T07:55:01.075' description='Build gitian-win failed with exit code 1']
[07:55:01] :	 [Step 1/1]  * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
[07:55:01] :	 [Step 1/1]  * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
[07:55:01] :	 [Step 1/1]  * [new branch]          master                 -> master
[07:55:01] :	 [Step 1/1] --- Building for bullseye amd64 ---
[07:55:01] :	 [Step 1/1] Stopping target if it is up
[07:55:01] :	 [Step 1/1] Error response from daemon: No such container: gitian-target
[07:55:01] :	 [Step 1/1] Error: No such container: gitian-target
[07:55:01] :	 [Step 1/1] Making a new image copy
[07:55:01] :	 [Step 1/1] Starting target
[07:55:01] :	 [Step 1/1] Checking if target is up.
[07:55:01] :	 [Step 1/1] Preparing build environment
[07:55:01] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[07:55:01] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[07:55:01] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[07:55:01] :	 [Step 1/1] Creating package manifest
[07:55:01] :	 [Step 1/1] Creating build script (var/build-script)
[07:55:01] :	 [Step 1/1] Running build script (log in var/build.log)
[07:55:01] :	 [Step 1/1] ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:185:in `build_one_configuration'
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:339:in `block (2 levels) in <main>'
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:334:in `each'
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:334:in `block in <main>'
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:332:in `each'
[07:55:01] :	 [Step 1/1] 	from ./bin/gbuild:332:in `<main>'
[07:55:01] :	 [Step 1/1] Build gitian-win failed with exit code 1
[07:55:01]W:	 [Step 1/1] + RESULT=1
[07:55:01]W:	 [Step 1/1] + pushd /home/teamcity/infra
[07:55:01]W:	 [Step 1/1] + docker-compose stop apt-cache-proxy
[07:55:01] :	 [Step 1/1] ~/infra ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:55:01]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ... 
[07:55:12] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[07:55:12]W:	 [Step 1/1]  [1A [2K
[07:55:12]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ...  [32mdone [0m
[07:55:12]W:	 [Step 1/1]  [1B+ popd
[07:55:12]W:	 [Step 1/1] + exit 1
[07:55:12]W:	 [Step 1/1] Process exited with code 1
[07:55:12]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[07:55:12] :	 [Step 1/1] Waiting for 1 service processes to complete
[07:55:12]E:	 [Step 1/1] Ant JUnit report watcher
[07:55:12]E:		 [Ant JUnit report watcher] No reports found for paths:
[07:55:12]E:		 [Ant JUnit report watcher] /home/teamcity/buildAgent/work/jailed-build/results/artifacts/junit/*.xml
[07:55:12]E:	 [Step 1/1] Step Command Line failed
[07:55:13]E: Ant JUnit report watcher
[07:55:13]E:	 [Ant JUnit report watcher] No reports found for paths:
[07:55:13]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[07:55:13]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[07:55:13] : Publishing internal artifacts (3s)
[07:55:15] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[07:55:15] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[07:55:13]W: Publishing artifacts (5s)
[07:55:13] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml, +:bitcoin-abc/abc-ci-builds/gitian-win/gitian-results => gitian-win.tar.gz]
[07:55:13]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[07:55:13] :	 [Publishing artifacts] Creating archive gitian-win.tar.gz
[07:55:13] :		 [Creating archive gitian-win.tar.gz] Creating /home/teamcity/buildAgent/temp/buildTmp/TarPreprocessor8805100377474412830/gitian-win.tar.gz
[07:55:13] :		 [Creating archive gitian-win.tar.gz] Archive was created, file size 375.9 KB (384924 bytes)
[07:55:17] :	 [Publishing artifacts] Publishing 1 file using [ArtifactsCachePublisher]: bitcoin-abc/abc-ci-builds/gitian-win/gitian-results => gitian-win.tar.gz
[07:55:17] :	 [Publishing artifacts] Publishing 1 file using [WebPublisher]: bitcoin-abc/abc-ci-builds/gitian-win/gitian-results => gitian-win.tar.gz
[07:55:19] : Build finished

Tail of the build log:

[08:05:39] :	 [Step 1/1]  * [new tag]             phabricator/diff/39371 -> phabricator/diff/39371
[08:05:39] :	 [Step 1/1]  * [new tag]             phabricator/diff/39373 -> phabricator/diff/39373
[08:05:39] :	 [Step 1/1]  * [new tag]             phabricator/diff/39384 -> phabricator/diff/39384
[08:05:39] :	 [Step 1/1]  * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
[08:05:39] :	 [Step 1/1]  * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
[08:05:39] :	 [Step 1/1]  * [new branch]          master                 -> master
[08:05:39] :	 [Step 1/1] --- Building for bullseye amd64 ---
[08:05:39] :	 [Step 1/1] Stopping target if it is up
[08:05:39] :	 [Step 1/1] Making a new image copy
[08:05:39] :	 [Step 1/1] Starting target
[08:05:39] :	 [Step 1/1] Checking if target is up.
[08:05:39] :	 [Step 1/1] Preparing build environment
[08:05:39] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[08:05:39] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[08:05:39] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[08:05:39] :	 [Step 1/1] Creating package manifest
[08:05:39] :	 [Step 1/1] Creating build script (var/build-script)
[08:05:39] :	 [Step 1/1] Running build script (log in var/build.log)
[08:05:39] :	 [Step 1/1] ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:185:in `build_one_configuration'
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:339:in `block (2 levels) in <main>'
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:334:in `each'
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:334:in `block in <main>'
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:332:in `each'
[08:05:39] :	 [Step 1/1] 	from ./bin/gbuild:332:in `<main>'
[08:05:39] :	 [Step 1/1] Build gitian-linux failed with exit code 1
[08:05:39]W:	 [Step 1/1] + RESULT=1
[08:05:39]W:	 [Step 1/1] + pushd /home/teamcity/infra
[08:05:39]W:	 [Step 1/1] + docker-compose stop apt-cache-proxy
[08:05:39] :	 [Step 1/1] ~/infra ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:05:40]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ... 
[08:05:50]W:	 [Step 1/1]  [1A [2K
[08:05:50]W:	 [Step 1/1] Stopping abc-apt-cache-proxy ...  [32mdone [0m
[08:05:50]W:	 [Step 1/1]  [1B
[08:05:50]W:	 [Step 1/1] + popd
[08:05:50]W:	 [Step 1/1] + exit 1
[08:05:50] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[08:05:50]W:	 [Step 1/1] Process exited with code 1
[08:05:50]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[08:05:50] :	 [Step 1/1] Waiting for 1 service processes to complete
[08:05:51]E:	 [Step 1/1] Ant JUnit report watcher
[08:05:51]E:		 [Ant JUnit report watcher] No reports found for paths:
[08:05:51]E:		 [Ant JUnit report watcher] /home/teamcity/buildAgent/work/jailed-build/results/artifacts/junit/*.xml
[08:05:51]E:	 [Step 1/1] Step Command Line failed
[08:05:51]E: Ant JUnit report watcher
[08:05:51]E:	 [Ant JUnit report watcher] No reports found for paths:
[08:05:51]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[08:05:51]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[08:05:51] : Publishing internal artifacts (4s)
[08:05:56] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[08:05:56] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[08:05:51]W: Publishing artifacts (6s)
[08:05:51] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml, +:bitcoin-abc/abc-ci-builds/gitian-linux/gitian-results => gitian-linux.tar.gz]
[08:05:51]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[08:05:51] :	 [Publishing artifacts] Creating archive gitian-linux.tar.gz
[08:05:51] :		 [Creating archive gitian-linux.tar.gz] Creating /home/teamcity/buildAgent/temp/buildTmp/TarPreprocessor6568042133334523965/gitian-linux.tar.gz
[08:05:52] :		 [Creating archive gitian-linux.tar.gz] Archive was created, file size 1.14 MB (1197304 bytes)
[08:05:57] :	 [Publishing artifacts] Publishing 1 file using [WebPublisher]: bitcoin-abc/abc-ci-builds/gitian-linux/gitian-results => gitian-linux.tar.gz
[08:05:57] :	 [Publishing artifacts] Publishing 1 file using [ArtifactsCachePublisher]: bitcoin-abc/abc-ci-builds/gitian-linux/gitian-results => gitian-linux.tar.gz
[08:05:58] : Build finished

@bot gitian-win gitian-linux gitian-osx

@bot gitian-win gitian-linux gitian-osx

PiRK published this revision for review.Apr 7 2023, 09:24
Fabien requested changes to this revision.Apr 7 2023, 09:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/modules/BinaryTest.cmake
10

We should not fail at the cmake stage if c++filt is not available. Most users/builders won't run this sript.
You can still run find_program and print a warning but let's not abort the whole build.

This revision now requires changes to proceed.Apr 7 2023, 09:33

revert unneccessary cmake changes (the knew determine_wellknown_cmd function does the same thing)

This revision is now accepted and ready to land.Apr 7 2023, 13:05