Page MenuHomePhabricator
Differential D13628

[Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly
ClosedPublic
Actions

Authored by tobias_ruck on Apr 8 2023, 12:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa7b0f33cf48a: [Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly
Summary

Encapsulates what we need to query blocks. This allows us to more easily add more data required for serving blocks, e.g. the current avalanche height.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-query-blocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23100
Build 45820: Build Diffbuild-chronik
Build 45819: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 8 2023, 12:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 12:15
tobias_ruck requested review of this revision.Apr 8 2023, 12:15
Harbormaster completed remote builds in B23100: Diff 39425.Apr 8 2023, 12:29
tobias_ruck added a child revision: D13626: [Chronik] Add avalanche support.Apr 8 2023, 13:57
Fabien requested changes to this revision.Apr 9 2023, 11:31
Fabien added inline comments.
chronik/chronik-indexer/src/query/blocks.rs
38

I don't think so

This revision now requires changes to proceed.Apr 9 2023, 11:31
tobias_ruck updated this revision to Diff 39627.Apr 12 2023, 15:03

fix comment for by_hash_or_height

Fabien accepted this revision.Apr 12 2023, 15:23
This revision is now accepted and ready to land.Apr 12 2023, 15:23
Harbormaster completed remote builds in B23241: Diff 39627.Apr 12 2023, 16:11
Closed by commit rABCa7b0f33cf48a: [Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly (authored by tobias_ruck). · Explain WhyApr 12 2023, 16:48
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCa7b0f33cf48a: [Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
26 lines
chronik-indexer/
src/
19 lines
query/
66 lines
2 lines

Diff 39425

View Options

chronik/chronik-http/src/server.rs

Loading...
View Options

chronik/chronik-indexer/src/indexer.rs

Loading...
View Options

chronik/chronik-indexer/src/query/blocks.rs

Loading...
View Options

chronik/chronik-indexer/src/query/mod.rs

Loading...