Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4d6340865088: [alias-server] Unit tests for main.js

Summary

T3060

Depends on D13644

Add unit tests for main

Patch bug found by introduction of test to correctly pass address param

Test Plan

npm test
node index.js`, app starts up, waits 10s, gives block height and hash of avalanche final block

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23145
Build 45910: Build Diff
Build 45909: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 8 2023, 23:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 23:21

bytesofman requested review of this revision.Apr 8 2023, 23:21

Harbormaster completed remote builds in B23125: Diff 39450.Apr 8 2023, 23:22

unit tests

Harbormaster completed remote builds in B23126: Diff 39451.Apr 8 2023, 23:44

bytesofman retitled this revision from [alias-server] Patch bug to correctly pass address param to [alias-server] Unit tests for main.js.Apr 8 2023, 23:44

bytesofman edited the summary of this revision. (Show Details)

Patch bug found by introduction of test to correctly pass address param

Where is that bug ? If the culprit is not landed already you should avoid introducing it rather than fixing it.

This revision now requires changes to proceed.Apr 9 2023, 09:26

In D13645#303363, @Fabien wrote:

Patch bug found by introduction of test to correctly pass address param

Where is that bug ? If the culprit is not landed already you should avoid introducing it rather than fixing it.

Was introduced before this stack. address is needed as a param to pass to initializeWebsocket

This was done properly in the unit tests. But was omitted in index.js, which called the function incorrectly.

bytesofman requested review of this revision.Apr 10 2023, 14:52

rebase

Harbormaster completed remote builds in B23145: Diff 39479.Apr 10 2023, 14:54

Fabien accepted this revision.Apr 10 2023, 19:12

This revision is now accepted and ready to land.Apr 10 2023, 19:12

rebase, carrying through unit test change

Harbormaster completed remote builds in B23212: Diff 39563.Apr 11 2023, 18:28

Closed by commit rABC4d6340865088: [alias-server] Unit tests for main.js (authored by bytesofman). · Explain WhyApr 12 2023, 14:20

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC4d6340865088: [alias-server] Unit tests for main.js.