Page MenuHomePhabricator
Differential D13670

Rename hash to txid for COutPoint in the test framework
ClosedPublic
Actions

Authored by sdulfari on Apr 11 2023, 16:01.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6456cdacf8f2: Rename hash to txid for COutPoint in the test framework
Summary

This fixes two issues:

  1. hash as used in COutPoint init() shadows a python builtin.
  2. hash is actually txid in the rest of the code base.
Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coutpoint-hash-to-txid
Lint
Lint Errors
SeverityLocationCodeMessage
Errortest/functional/test_framework/messages.py:1007A002flake8 A002
Errortest/functional/test_framework/messages.py:1074A002flake8 A002
Unit
No Test Coverage
Build Status
Buildable 23204
Build 46027: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 46026: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 11 2023, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 16:01
sdulfari requested review of this revision.Apr 11 2023, 16:01
Harbormaster completed remote builds in B23204: Diff 39551.Apr 11 2023, 16:01
sdulfari added a comment.Apr 11 2023, 16:04

Apparently the lint errors come from my local machine since I have flake8-builtins installed. Please ignore for now. I will get to those soon.

PiRK accepted this revision.Apr 11 2023, 17:27
PiRK added a subscriber: PiRK.

In messages.CTransaction, it is called sha256

This revision is now accepted and ready to land.Apr 11 2023, 17:27
PiRK added a comment.Apr 11 2023, 17:31
In D13670#304109, @PiRK wrote:

In messages.CTransaction, it is called sha256

And there is also a CTransaction.hash which is a hex string version of the txid

This revision was landed with ongoing or failed builds.Apr 11 2023, 17:36
Closed by commit rABC6456cdacf8f2: Rename hash to txid for COutPoint in the test framework (authored by sdulfari). · Explain Why
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC6456cdacf8f2: Rename hash to txid for COutPoint in the test framework.
PiRK mentioned this in D16022: [test] fix broken interface_usdt_utxocache.py test.Fri, Apr 19, 11:16
PiRK mentioned this in rABC35519a7612cf: [test] fix broken interface_usdt_utxocache.py test.Fri, Apr 19, 12:09

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
data/
2 lines
2 lines
4 lines
4 lines
test_framework/
14 lines

Diff 39551

View Options

test/functional/abc_p2p_proof_inventory.py

Loading...
View Options

test/functional/data/invalid_txs.py

Loading...
View Options

test/functional/feature_utxo_set_hash.py

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/mining_basic.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...