Differential D13676

[CI] Fix diff regex for JS Mocha templates
ClosedPublic
Actions

Authored by Fabien on Apr 11 2023, 20:19.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC25e2894ebc02: [CI] Fix diff regex for JS Mocha templates

Summary

The runOnDiffRegex value doesn't expand the environment variables (and shouldn't) causing the match to fail.

Test Plan

See the diffs like D13634 stopped running on CI after the regex moved to the template.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_ci_regex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23214
Build 46047: Build Diff
Build 46046: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 11 2023, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 20:19

Fabien requested review of this revision.Apr 11 2023, 20:19

Harbormaster completed remote builds in B23214: Diff 39569.Apr 11 2023, 20:20

sdulfari accepted this revision.Apr 11 2023, 20:22

This revision is now accepted and ready to land.Apr 11 2023, 20:22

Closed by commit rABC25e2894ebc02: [CI] Fix diff regex for JS Mocha templates (authored by Fabien). · Explain WhyApr 11 2023, 20:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC25e2894ebc02: [CI] Fix diff regex for JS Mocha templates.

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.yml

6 lines

Diff 39569

View Options

contrib/teamcity/build-configurations.yml

[CI] Fix diff regex for JS Mocha templatesClosedPublicActions