Page MenuHomePhabricator
Differential D18958

[cmake] Add a target for the proof-manager-cli tool
ClosedPublic
Actions

Authored by Fabien on Tue, Nov 18, 16:21.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa569b425ae1b: [cmake] Add a target for the proof-manager-cli tool
Summary

Make it easy to build (via ninja) and install (via install-proof-manager-cli) the proof manager CLI tool.

Note that this is still gated behind a flag to avoid making Rust a mandatory dependency for the node.

Depends on D18956.

Test Plan
cmake -GNinja .. -DBUILD_PROOF_MANAGER_CLI=ON
ninja # Builds the proof-manager-cli
ninja install-proof-manager-cli
ninja check-proof-manager-cli

./contrib/teamcity/build-configurations.py proof-manager-cli

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Nov 18, 16:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 18, 16:21
Fabien requested review of this revision.Tue, Nov 18, 16:21
Fabien added a child revision: D18959: [guix] Add the proof-manager-cli to the release.
Harbormaster completed remote builds in B35102: Diff 56658.Tue, Nov 18, 16:37
PiRK added a subscriber: PiRK.Tue, Nov 18, 19:58
PiRK added inline comments.
contrib/teamcity/build-configurations.yml
759 ↗(On Diff #56658)

Would it make sense to disable most other components (-DBUILD_BITCOIN_CLI=OFF -DBUILD_WALLET=OFF....) to speed up the build?

PiRK added inline comments.Tue, Nov 18, 20:00
contrib/teamcity/build-configurations.yml
759 ↗(On Diff #56658)

Nvm, you already call a very specific target so it will not build any piece of the node.

Fabien added inline comments.Tue, Nov 18, 20:46
contrib/teamcity/build-configurations.yml
759 ↗(On Diff #56658)

yes this would only save the related cmake time which is not much

PiRK accepted this revision.Wed, Nov 19, 08:06
This revision is now accepted and ready to land.Wed, Nov 19, 08:06
Closed by commit rABCa569b425ae1b: [cmake] Add a target for the proof-manager-cli tool (authored by Fabien). · Explain WhyWed, Nov 19, 08:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa569b425ae1b: [cmake] Add a target for the proof-manager-cli tool.

Revision Contents
Changeset List

PathSize
5 lines
apps/
proof-manager-cli/
100 lines
contrib/
teamcity/
9 lines

Diff 56667

View Options

CMakeLists.txt

Loading...
View Options

apps/proof-manager-cli/CMakeLists.txt

Loading...
View Options

contrib/teamcity/build-configurations.yml

Loading...