add symlink option
AbandonedPublic
Actions

Authored by jasonbcox on May 3 2018, 14:39.

Details

Reviewers

deadalnix
jonald_fyookball

Group Reviewers

Restricted Project

Summary

port changes from https://github.com/bitcoin/bitcoin/pull/11343

This allows user to set the -walletallowsymboliclink option when
running the wallet. If set, then the wallet file is allowed to
be a symbolic link. If false, the wallet file is prohibited
from being a symbolic link, which is the default behavior.

Test Plan

cd into ~/.bitcoin folder
move existing wallet.dat to temporary location
create symlink called wallet.dat that points to actual wallet file.
run bitcoin-qt.
message should appear that wallet file is invalid.
run bitcoin-qt -walletallowsymboliclink=1
message shouldnt appear. wallet should load normally.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

jonald-branch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2493
Build 3114: Bitcoin ABC Buildbot (legacy)
Build 3113: arc lint + arc unit

Event Timeline

jonald_fyookball created this revision.May 3 2018, 14:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 14:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2493: Diff 3753!May 3 2018, 15:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

I don't know if this is a good idea. We don't allow wallets to be symlinks or outside the datadir for good reason (they're not self-sufficient files).