T3104
Rename websocket.js files that are not actually creating a websocket
Differential D13684
[node apps with websocket] Rename websocket handler file bytesofman on Apr 12 2023, 14:33. Authored by
Details
T3104 Rename websocket.js files that are not actually creating a websocket npm test
Diff Detail
Event TimelineComment Actions handleChronikWs sounds like a function, but it could be ChronikWsHandler or ChronikWsInterface Comment Actions Reason for chronikWsHandler vs ChronikWsHandler - the files are a collection of functions, not a component or its own class. Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.
Tail of the build log: Error: Cannot find module './handleChronikWs' Require stack: - /work/apps/ecash-herald/src/main.js - /work/apps/ecash-herald/test/mainTests.js at Function.Module._resolveFilename (node:internal/modules/cjs/loader:924:15) at Function.Module._load (node:internal/modules/cjs/loader:769:27) at Module.require (node:internal/modules/cjs/loader:996:19) at require (node:internal/modules/cjs/helpers:92:18) at Object.<anonymous> (/work/apps/ecash-herald/src/main.js:5:144) at Module._compile (node:internal/modules/cjs/loader:1092:14) at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13) at Module._extensions..js (node:internal/modules/cjs/loader:1121:10) at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4) at Module.load (node:internal/modules/cjs/loader:972:32) at Function.Module._load (node:internal/modules/cjs/loader:813:14) at Module.require (node:internal/modules/cjs/loader:996:19) at require (node:internal/modules/cjs/helpers:92:18) at Object.<anonymous> (/work/apps/ecash-herald/test/mainTests.js:8:18) at Module._compile (node:internal/modules/cjs/loader:1092:14) at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13) at Module._extensions..js (node:internal/modules/cjs/loader:1121:10) at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4) at Module.load (node:internal/modules/cjs/loader:972:32) at Function.Module._load (node:internal/modules/cjs/loader:813:14) at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:201:29) at ModuleJob.run (node:internal/modules/esm/module_job:154:23) at async Loader.import (node:internal/modules/esm/loader:177:24) at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15) at async formattedImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:9:14) at async Object.exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:42:28) at async Object.exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20) at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3) at async Object.exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5) ----------------------|---------|----------|---------|---------|------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ----------------------|---------|----------|---------|---------|------------------- All files | 6.35 | 0 | 0 | 6.6 | ecash-herald | 100 | 100 | 100 | 100 | config.js | 100 | 100 | 100 | 100 | ecash-herald/src | 5.95 | 0 | 0 | 6.19 | chronikWsHandler.js | 18.75 | 0 | 0 | 18.75 | 17-60 events.js | 17.39 | 0 | 0 | 17.39 | 25-92 main.js | 9.09 | 0 | 0 | 9.09 | 8-49 parse.js | 2.09 | 0 | 0 | 2.2 | 10-343 utils.js | 7.14 | 0 | 0 | 7.5 | 11-99 ----------------------|---------|----------|---------|---------|------------------- ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='15'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='236'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='89'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='18'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='15'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='227'] ##teamcity[blockClosed name='Code Coverage Summary'] mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory Build ecash-herald-tests failed with exit code 1 |