Page MenuHomePhabricator
Differential D1369

[mempool] Bless the mempool with it's own reference to config
AbandonedPublic
Actions

Authored by schancel on May 3 2018, 20:30.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Summary

As per title

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mempool-config
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2495
Build 3118: Bitcoin ABC Buildbot (legacy)
Build 3117: arc lint + arc unit

Event Timeline

schancel created this revision.May 3 2018, 20:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2018, 20:30
teamcity added a subscriber: teamcity.May 3 2018, 20:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox accepted this revision.May 3 2018, 20:49
This revision is now accepted and ready to land.May 3 2018, 20:49
teamcity added a comment.May 3 2018, 20:54

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2495: Diff 3755!May 3 2018, 20:54
deadalnix added a subscriber: deadalnix.May 4 2018, 14:31
deadalnix added inline comments.
src/validation.cpp
686

So this is kind of a problem, because UpdateMempoolForReorg is passed a config, but then we end up using a potentially different config. WHat's the larger picture here ?

deadalnix added inline comments.May 4 2018, 14:35
src/validation.cpp
686

Maybe logging a warning if the config mismatch ? As logging as we are moving toward something that's consistent by default, it's great.

schancel abandoned this revision.May 4 2018, 15:00

Revision Contents
Changeset List

PathSize
src/
3 lines
8 lines
2 lines

Diff 3755

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...