Differential D13690

[CI] Use 80 as a default port for previews
ClosedPublic
Actions

Authored by Fabien on Apr 12 2023, 20:13.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf228133d37db: [CI] Use 80 as a default port for previews

Summary

The actual behavior is to not provide port translation if no port is specified, which is not very useful. Default to 80 (http) instead.
Since none of the currently supported websites are missing the port: config, there is no change in behavior.

Test Plan

./contrib/teamcity/build-configurations.py preview-e.cash

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ci_preview_port_default_80

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23254
Build 46127: Build Diff
Build 46126: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 12 2023, 20:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2023, 20:13

Fabien requested review of this revision.Apr 12 2023, 20:13

Harbormaster completed remote builds in B23254: Diff 39646.Apr 12 2023, 20:13

PiRK accepted this revision.Apr 13 2023, 07:28

This revision is now accepted and ready to land.Apr 13 2023, 07:28

Closed by commit rABCf228133d37db: [CI] Use 80 as a default port for previews (authored by Fabien). · Explain WhyApr 13 2023, 08:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf228133d37db: [CI] Use 80 as a default port for previews.

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.py

4 lines

Diff 39646

View Options

contrib/teamcity/build-configurations.py

[CI] Use 80 as a default port for previewsClosedPublicActions