Paths

Table of Contentst

Differential D13693

[Chronik] Use struct init for `QueryTxs` instead of `new`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 12 2023, 21:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC91da94b6cded: [Chronik] Use struct init for `QueryTxs` instead of `new`

Summary

While using new is fine, once we add more fields to QueryTxs using positional parameters becomes less readable, so we use the clearer struct init.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-refactor-query-txs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23259
Build 46137: Build Diff	build-chronik
Build 46136: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 12 2023, 21:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2023, 21:53

tobias_ruck requested review of this revision.Apr 12 2023, 21:53

tobias_ruck added a child revision: D13626: [Chronik] Add avalanche support.Apr 12 2023, 21:55

Harbormaster completed remote builds in B23259: Diff 39654.Apr 12 2023, 22:45

Fabien accepted this revision.Apr 13 2023, 08:54

This revision is now accepted and ready to land.Apr 13 2023, 08:54

Closed by commit rABC91da94b6cded: [Chronik] Use struct init for `QueryTxs` instead of `new` (authored by tobias_ruck). · Explain WhyApr 13 2023, 12:12

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC91da94b6cded: [Chronik] Use struct init for `QueryTxs` instead of `new`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-indexer/

src/

indexer.rs

5 lines

query/

txs.rs

11 lines

Diff 39654

View Options

chronik/chronik-indexer/src/indexer.rs