Page MenuHomePhabricator
Differential D13697

[herald] Create msg lines while iterating over parsed txs
ClosedPublic
Actions

Authored by bytesofman on Apr 13 2023, 11:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCea2d4baa5a3c: [herald] Create msg lines while iterating over parsed txs
Summary

T2972

Since app was built up incrementally, this inefficiency was overlooked.

parsedTxs has all the info necessary to create a tg msg line. It doesn't make sense to iterate over parsedTxs to create more parsed info arrays, then iterate over those to create msg lines.

Create msg lines while iterating over parsedTxs. Then organize them.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-line-for-all-parsed-txs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23271
Build 46161: Build Diffecash-herald-tests
Build 46160: arc lint + arc unit

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
2 lines
88 lines
test/
mocks/

Diff 39670

View Options

apps/ecash-herald/src/main.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...