Differential D13703

[ecashaddrjs] Ensure README displays at npmjs page
ClosedPublic
Actions

Authored by bytesofman on Apr 13 2023, 15:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCabb631b909a9: [ecashaddrjs] Ensure README displays at npmjs page

Summary

T3119

Not sure what's going on here. README worked for 1.3.0, not for 1.4.0. However if I try reverting to the 1.3.0 README, no good, doesn't work. Maybe something has changed with how the file is linted.

Will come back to this after working on other things and see if I realize what I'm overlooking.

Test Plan

need to publish this to npm to see how the readme is shown on their site. Currently still not working.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-readme-take-two

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23286
Build 46191: Build Diff	ecashaddrjs-tests
Build 46190: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 13 2023, 15:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2023, 15:55

bytesofman requested review of this revision.Apr 13 2023, 15:55

bytesofman planned changes to this revision.Apr 13 2023, 15:55

update version in package-lock

Harbormaster completed remote builds in B23285: Diff 39696.Apr 13 2023, 15:56

Harbormaster completed remote builds in B23286: Diff 39697.

bytesofman planned changes to this revision.Apr 13 2023, 16:10

hm now this "just works"

Issue is probably some kind of caching at the npmjs page where it takes some time for the README to be parsed and recognized before it's being displayed.

readme fixes

Okay -- this version is now up and the README is working. Weird. Might have just been an issue with npmjs site.

https://www.npmjs.com/package/ecashaddrjs

Harbormaster completed remote builds in B23324: Diff 39749.Apr 14 2023, 15:39

Fabien accepted this revision.Apr 14 2023, 21:27

This revision is now accepted and ready to land.Apr 14 2023, 21:27

Closed by commit rABCabb631b909a9: [ecashaddrjs] Ensure README displays at npmjs page (authored by bytesofman). · Explain WhyApr 14 2023, 21:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCabb631b909a9: [ecashaddrjs] Ensure README displays at npmjs page.