Paths

Table of Contentst

Differential D13720

[alias-server] Modify getValidAliasRegistrations to work with partial tx history
ClosedPublic
Actions

Authored by bytesofman on Apr 14 2023, 14:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd2ce06f023b3: [alias-server] Modify getValidAliasRegistrations to work with partial tx history

Summary

T3060

The getValidAliasRegistrations function currently only works if input is full history of all txs with valid alias prefix and fee.

Allow this function to take a parameter of previously valid registered aliases to return only newly registered aliases.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 14 2023, 14:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2023, 14:34

bytesofman requested review of this revision.Apr 14 2023, 14:34

Harbormaster completed remote builds in B23321: Diff 39746.Apr 14 2023, 14:36

bytesofman added a child revision: D13721: [alias-server] Helper function to get array of strings with just alias names.Apr 14 2023, 14:45

Fabien accepted this revision.Apr 14 2023, 21:29

This revision is now accepted and ready to land.Apr 14 2023, 21:29

Closed by commit rABCd2ce06f023b3: [alias-server] Modify getValidAliasRegistrations to work with partial tx history (authored by bytesofman). · Explain WhyApr 14 2023, 21:55

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd2ce06f023b3: [alias-server] Modify getValidAliasRegistrations to work with partial tx history.

Revision Contents
Changeset List

Path

Size

apps/

alias-server/

src/

alias.js

14 lines

test/

aliasTests.js

34 lines

Diff 39760

View Options

apps/alias-server/src/alias.js