util: Avoid buggy std::filesystem:::create_directories() call
ClosedPublic
Actions

Authored by PiRK on Apr 18 2023, 12:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC89247877f79b: util: Avoid buggy std::filesystem:::create_directories() call

Summary

Compiled with some libstdc++ versions (e.g., on Ubuntu 20.04, Debian 11) std::filesystem:::create_directories() call fails to handle symbol links
properly.

This is a backport of core#24266

Note that this fixes also a redundant "/" being added to path when BaseParams().DataDir().empty(), so this is a dependency for D13730

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 18 2023, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2023, 12:49

PiRK requested review of this revision.Apr 18 2023, 12:49

teamcity edited the summary of this revision. (Show Details)Apr 18 2023, 12:49

PiRK added a child revision: D12017: [cmake] link necessary lib for std::filesystem.Apr 18 2023, 12:54

PiRK mentioned this in D13730: Drop StripRedundantLastElementsOfPath() function.Apr 18 2023, 12:57

Harbormaster completed remote builds in B23352: Diff 39790.Apr 18 2023, 13:09

Fabien accepted this revision.Apr 18 2023, 14:43

This revision is now accepted and ready to land.Apr 18 2023, 14:43

Closed by commit rABC89247877f79b: util: Avoid buggy std::filesystem:::create_directories() call (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyApr 18 2023, 18:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC89247877f79b: util: Avoid buggy std::filesystem:::create_directories() call.

Revision Contents
Changeset List

Path

Size

src/

util/

system.cpp

13 lines

Diff 39798

View Options

util: Avoid buggy std::filesystem:::create_directories() callClosedPublicActions