Differential D13742

[lint] Fix variables shadowing python builtins in abc_p2p_avalanche_transaction_voting.py
ClosedPublic
Actions

Authored by sdulfari on Apr 19 2023, 18:04.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC27583ce28e3b: [lint] Fix variables shadowing python builtins in…

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting
flake8 abc_p2p_avalanche_transaction_voting.py | grep A001  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-p2p-ava-tx-voting

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23372
Build 46363: Build Diff	build-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang
Build 46362: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 19 2023, 18:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2023, 18:04

sdulfari requested review of this revision.Apr 19 2023, 18:04

Harbormaster completed remote builds in B23372: Diff 39813.Apr 19 2023, 18:21

PiRK accepted this revision.Apr 19 2023, 19:16

This revision is now accepted and ready to land.Apr 19 2023, 19:16

Closed by commit rABC27583ce28e3b: [lint] Fix variables shadowing python builtins in… (authored by sdulfari). · Explain WhyApr 19 2023, 20:17

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC27583ce28e3b: [lint] Fix variables shadowing python builtins in….

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_transaction_voting.py

10 lines

Diff 39813

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

[lint] Fix variables shadowing python builtins in abc_p2p_avalanche_transaction_voting.pyClosedPublicActions