Differential D13749

[lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py
ClosedPublic
Actions

Authored by sdulfari on Apr 20 2023, 18:46.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC374f5aafce0a: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py

Summary

Ignore A001 since we are explicitly overridding the builtin behavior. Overridding builtins is very hacky but this should be backported out of the code base in the future so it is not worth worrying about.

Test Plan

flake8 contrib/testgen/base58.py | grep A001  # empty

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-testgen

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23387
Build 46393: Build Diff
Build 46392: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 20 2023, 18:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2023, 18:46

sdulfari requested review of this revision.Apr 20 2023, 18:46

Harbormaster completed remote builds in B23387: Diff 39838.Apr 20 2023, 18:46

sdulfari added a child revision: D13751: [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward.Apr 20 2023, 19:52

Oh god, this is awful python 2 + 3 compatibility code.

Will be removed by core#24576

This revision is now accepted and ready to land.Apr 21 2023, 06:31

Closed by commit rABC374f5aafce0a: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py (authored by sdulfari). · Explain WhyApr 21 2023, 15:30

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC374f5aafce0a: [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py.

Revision Contents
Changeset List

Path

Size

contrib/

testgen/

base58.py

4 lines

Diff 39838

View Options

[lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.pyClosedPublicActions