Page MenuHomePhabricator

port addrman changes
AbandonedPublic

Authored by jasonbcox on May 5 2018, 00:42.

Details

Reviewers
deadalnix
jonald_fyookball
Group Reviewers
Restricted Project
Summary

Port addrman changes , antisybil measures from bitcoin core

Test Plan
  1. cd into .bitcoin directory
  2. make check for unit tests
  3. from test directory, test_runner.py
  4. make sure all tests pass
  5. run wallet, make sure it is connecting to nodes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
jonald-branch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2512
Build 3147: Bitcoin ABC Buildbot (legacy)
Build 3146: arc lint + arc unit

Event Timeline

schancel added inline comments.
src/addrman.cpp
532

What's with this _?

jasonbcox added inline comments.
src/addrman.cpp
532

It's an old style convention where _X() or X_() refers to a private function or helper implementation of X().

deadalnix requested changes to this revision.May 6 2018, 13:54
deadalnix added a subscriber: deadalnix.

The code formatting is fubared all over the place, the diff title doesn't provide any information as what this is doing, nor the description. I have no idea what is the problem this is solving or how i solve this unknown problem in any way, nor even what code it is backporting.

This revision now requires changes to proceed.May 6 2018, 13:54
jasonbcox abandoned this revision.
jasonbcox added a reviewer: jonald_fyookball.

This change is already in: https://reviews.bitcoinabc.org/D1862