port addrman changes
AbandonedPublic
Actions

Authored by jasonbcox on May 5 2018, 00:42.

Details

Reviewers

deadalnix
jonald_fyookball

Group Reviewers

Restricted Project

Summary

Port addrman changes , antisybil measures from bitcoin core

Test Plan

cd into .bitcoin directory
make check for unit tests
from test directory, test_runner.py
make sure all tests pass
run wallet, make sure it is connecting to nodes

Diff Detail

Repository

rABC Bitcoin ABC

Branch

jonald-branch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2512
Build 3147: Bitcoin ABC Buildbot (legacy)
Build 3146: arc lint + arc unit

Event Timeline

jonald_fyookball created this revision.May 5 2018, 00:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2018, 00:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2512: Diff 3774!May 5 2018, 00:43

schancel added a subscriber: schancel.May 5 2018, 17:29

schancel added inline comments.

src/addrman.cpp
532	What's with this _?

jasonbcox added a subscriber: jasonbcox.May 6 2018, 01:53

jasonbcox added inline comments.

src/addrman.cpp
532	It's an old style convention where _X() or X_() refers to a private function or helper implementation of X().

The code formatting is fubared all over the place, the diff title doesn't provide any information as what this is doing, nor the description. I have no idea what is the problem this is solving or how i solve this unknown problem in any way, nor even what code it is backporting.

This revision now requires changes to proceed.May 6 2018, 13:54