Differential D13751

[lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward
ClosedPublic
Actions

Authored by sdulfari on Apr 20 2023, 19:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5488cd9a97d3: [lint] Fix remaining variables shadowing python builtins and enable detection…

Summary

This is the last step cleaning up variables shadowing python builtins. Going forward the linter will catch these and report an error.

Depends on D13748, D13749, and D13750

Test Plan

ninja check-functional

From project root:

flake8 | grep A001

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-finish

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23389
Build 46397: Build Diff	build-debug · build-clang-tidy · build-clang · build-without-wallet · build-diff
Build 46396: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 20 2023, 19:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2023, 19:52

sdulfari requested review of this revision.Apr 20 2023, 19:52

Harbormaster completed remote builds in B23389: Diff 39840.Apr 20 2023, 20:06

PiRK accepted this revision.Apr 21 2023, 06:46

This revision is now accepted and ready to land.Apr 21 2023, 06:46

Closed by commit rABC5488cd9a97d3: [lint] Fix remaining variables shadowing python builtins and enable detection… (authored by sdulfari). · Explain WhyApr 21 2023, 15:30

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC5488cd9a97d3: [lint] Fix remaining variables shadowing python builtins and enable detection….

Revision Contents
Changeset List

Path

Size

.arclint

2 lines

test/

functional/

abc_rpc_isfinal.py

8 lines

p2p_add_connections.py

8 lines

rpc_rawtransaction.py

6 lines

wallet_coinbase_category.py

6 lines

wallet_send.py

8 lines

Diff 39840

View Options

.arclint

View Options

test/functional/abc_rpc_isfinal.py

View Options

test/functional/p2p_add_connections.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/wallet_coinbase_category.py

View Options

test/functional/wallet_send.py

[lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forwardClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39840

.arclint

test/functional/abc_rpc_isfinal.py

test/functional/p2p_add_connections.py

test/functional/rpc_rawtransaction.py

test/functional/wallet_coinbase_category.py

test/functional/wallet_send.py

[lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward
ClosedPublic
Actions

Revision Contents
Changeset List