[Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc.
ClosedPublic
Actions

Authored by tobias_ruck on Apr 24 2023, 14:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCaacda0fe4516: [Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc.

Summary

By inlining make_tx_proto in the match arms we don't need Cows anymore, and the code becomes simpler and more readable.

Note: No actual cows have been harmed in the production of this diff.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-refactor-query-txs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23419
Build 46457: Build Diff	build-chronik
Build 46456: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 24 2023, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2023, 14:25

tobias_ruck requested review of this revision.Apr 24 2023, 14:25

tobias_ruck added a child revision: D13759: [Chronik] Index spent_by + add `spent_by` to `Tx` protobuf.Apr 24 2023, 14:43

Harbormaster completed remote builds in B23419: Diff 39889.Apr 24 2023, 15:14

Fabien accepted this revision.Apr 24 2023, 16:18

This revision is now accepted and ready to land.Apr 24 2023, 16:18

Closed by commit rABCaacda0fe4516: [Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc. (authored by tobias_ruck). · Explain WhyApr 24 2023, 19:44

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCaacda0fe4516: [Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc..

Revision Contents
Changeset List

Path

Size

chronik/

chronik-indexer/

src/

query/

txs.rs

69 lines

Diff 39889

View Options

chronik/chronik-indexer/src/query/txs.rs

[Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc.ClosedPublicActions