Differential D13778

[GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGS
ClosedPublic
Actions

Authored by Fabien on Apr 25 2023, 14:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC15a3009d3c91: [GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGS

Summary

And remove the redundant flags.
This has the main benefit of erasing the dynamic loader so the binaries can run outside of the guix environment.

Test Plan

Run the guix build.
Copy the binaries to some other machine and check it runs.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 25 2023, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 25 2023, 14:45

Fabien requested review of this revision.Apr 25 2023, 14:45

Harbormaster completed remote builds in B23449: Diff 39930.Apr 25 2023, 14:46

PiRK accepted this revision.Apr 25 2023, 15:16

This revision is now accepted and ready to land.Apr 25 2023, 15:16

Closed by commit rABC15a3009d3c91: [GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGS (authored by Fabien). · Explain WhyApr 25 2023, 15:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC15a3009d3c91: [GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGS.

Revision Contents
Changeset List

Path

Size

contrib/

guix/

libexec/

build.sh

10 lines

Diff 39932

View Options

contrib/guix/libexec/build.sh

[GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGSClosedPublicActions