Paths

Table of Contentst

Differential D13779

[Chronik] Refactor: Change to `Mempool::remove_mined`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 25 2023, 18:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCae4e0eef843c: [Chronik] Refactor: Change to `Mempool::remove_mined`

Summary

Change removed_mined_txs to remove_mined, which only removes one tx but returns it.

Also harmonizes the name with the other remove_mined method (and fixes "removed" -> "remove").

Test Plan

ninja check-crates && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-mempool-remove_mined

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23455
Build 46529: Build Diff	build-chronik
Build 46528: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 25 2023, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 25 2023, 18:00

tobias_ruck requested review of this revision.Apr 25 2023, 18:00

Harbormaster completed remote builds in B23455: Diff 39939.Apr 25 2023, 18:13

tobias_ruck edited the summary of this revision. (Show Details)Apr 25 2023, 20:52

tobias_ruck added a child revision: D13781: [Chronik] Allow subscribing to WebSocket script updates.Apr 25 2023, 22:09

Fabien accepted this revision.Apr 26 2023, 09:37

This revision is now accepted and ready to land.Apr 26 2023, 09:37

Closed by commit rABCae4e0eef843c: [Chronik] Refactor: Change to `Mempool::remove_mined` (authored by tobias_ruck). · Explain WhyApr 26 2023, 10:45

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCae4e0eef843c: [Chronik] Refactor: Change to `Mempool::remove_mined`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-db/

src/

mem/

mempool.rs

24 lines

chronik-indexer/

src/

indexer.rs

8 lines

Diff 39939

View Options

chronik/chronik-db/src/mem/mempool.rs