Page MenuHomePhabricator

build: MacOS toolchain bump
ClosedPublic

Authored by PiRK on Apr 26 2023, 12:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8296d02abafa: build: MacOS toolchain bump
Summary

build: set OSX_MIN_VERSION to 10.15

This is required to use std::filesystem on macOS as support for it only
landed in the libc++ dylib shipped with 10.15.

See also: https://developer.apple.com/documentation/xcode-release-notes/xcode-11-release-notes

Clang now supports the C++17 <filesystem> library for iOS 13, macOS 10.15, watchOS 6, and tvOS 13.

Bump libtapi 1100.0.11, Clang 10.0.1, native cctools 973.0.1, ld64 609

LLVM 8 has inherent nondeterminism in the compiler, fixed in LLVM 9+.

build: Xcode 12.1, macOS SDK 10.15.6

build: no longer patch threading out of ld64

Changes introduced in ld64-450.3 have likely removed the need for us to patch out pthreads. See: https://opensource.apple.com/source/ld64/ld64-450.3/src/ld/InputFiles.cpp.auto.html.

build: use -stdlib++-isystem with Clang 10

This is a backport of core#22993 and core#19817

Depends on D13802

Test Plan

gitian-osx build-osx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr20470
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23473
Build 46565: Build Diff
Build 46564: arc lint + arc unit

Event Timeline

Tail of the build log:

 * [new tag]             phabricator/diff/39843 -> phabricator/diff/39843
 * [new tag]             phabricator/diff/39844 -> phabricator/diff/39844
 * [new tag]             phabricator/diff/39845 -> phabricator/diff/39845
 * [new tag]             phabricator/diff/39847 -> phabricator/diff/39847
 * [new tag]             phabricator/diff/39853 -> phabricator/diff/39853
 * [new tag]             phabricator/diff/39865 -> phabricator/diff/39865
 * [new tag]             phabricator/diff/39868 -> phabricator/diff/39868
 * [new tag]             phabricator/diff/39869 -> phabricator/diff/39869
 * [new tag]             phabricator/diff/39871 -> phabricator/diff/39871
 * [new tag]             phabricator/diff/39880 -> phabricator/diff/39880
 * [new tag]             phabricator/diff/39885 -> phabricator/diff/39885
 * [new tag]             phabricator/diff/39903 -> phabricator/diff/39903
 * [new tag]             phabricator/diff/39904 -> phabricator/diff/39904
 * [new tag]             phabricator/diff/39908 -> phabricator/diff/39908
 * [new tag]             phabricator/diff/39910 -> phabricator/diff/39910
 * [new tag]             phabricator/diff/39914 -> phabricator/diff/39914
 * [new tag]             phabricator/diff/39918 -> phabricator/diff/39918
 * [new tag]             phabricator/diff/39921 -> phabricator/diff/39921
 * [new tag]             phabricator/diff/39922 -> phabricator/diff/39922
 * [new tag]             phabricator/diff/39923 -> phabricator/diff/39923
 * [new tag]             phabricator/diff/39925 -> phabricator/diff/39925
 * [new tag]             phabricator/diff/39926 -> phabricator/diff/39926
 * [new tag]             phabricator/diff/39928 -> phabricator/diff/39928
 * [new tag]             phabricator/diff/39929 -> phabricator/diff/39929
 * [new tag]             phabricator/diff/39940 -> phabricator/diff/39940
 * [new tag]             phabricator/diff/39946 -> phabricator/diff/39946
 * [new tag]             phabricator/diff/39947 -> phabricator/diff/39947
 * [new tag]             phabricator/diff/39948 -> phabricator/diff/39948
 * [new tag]             phabricator/diff/39949 -> phabricator/diff/39949
 * [new tag]             phabricator/diff/39950 -> phabricator/diff/39950
 * [new tag]             phabricator/diff/39951 -> phabricator/diff/39951
 * [new tag]             phabricator/diff/39952 -> phabricator/diff/39952
 * [new tag]             phabricator/diff/39958 -> phabricator/diff/39958
 * [new tag]             phabricator/diff/39961 -> phabricator/diff/39961
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
lstat /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/contrib/gitian-builder/inputs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers.tar.gz: no such file or directory
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

Tail of the build log:

1 error generated.
...failed clang-linux.compile.c++.without-pch bin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/test_main.o...
clang-linux.compile.c++.without-pch bin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/unit_test_parameters.o

  "env" "-u" "C_INCLUDE_PATH" "-u" "CPLUS_INCLUDE_PATH" "-u" "OBJC_INCLUDE_PATH" "-u" "OBJCPLUS_INCLUDE_PATH" "-u" "CPATH" "-u" "LIBRARY_PATH" "/work/depends/x86_64-apple-darwin18/native/bin/clang++" "--target=x86_64-apple-darwin18" "-mmacosx-version-min=10.14" "-B/work/depends/x86_64-apple-darwin18/native/bin" "-mlinker-version=609" "--sysroot=/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers" "-stdlib=libc++" "-nostdinc++" "-Xclang" "-cxx-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include/c++/v1" "-Xclang" "-internal-externc-isystem/work/depends/x86_64-apple-darwin18/native/lib/clang/10.0.1/include" "-Xclang" "-internal-externc-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include" -c -x c++ -fvisibility-inlines-hidden -std=c++17 -fvisibility=hidden   -I/work/depends/x86_64-apple-darwin18/include -m64 -O3 -Wall -fvisibility=hidden -Wno-inline -Wno-c99-extensions -Wno-variadic-macros -DBOOST_ALL_NO_LIB=1 -DNDEBUG -I"." -o "bin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/unit_test_parameters.o" "libs/test/src/unit_test_parameters.cpp"

In file included from libs/test/src/unit_test_parameters.cpp:16:
In file included from ./boost/test/impl/unit_test_parameters.ipp:22:
In file included from ./boost/test/unit_test_parameters.hpp:18:
In file included from ./boost/test/detail/global_typedef.hpp:15:
In file included from ./boost/test/utils/basic_cstring/basic_cstring.hpp:20:
In file included from ./boost/test/utils/basic_cstring/basic_cstring_fwd.hpp:19:
In file included from ./boost/test/detail/config.hpp:16:
In file included from ./boost/config.hpp:44:
./boost/config/detail/select_stdlib_config.hpp:18:12: fatal error: 'cstddef' file not found
#  include <cstddef>
           ^~~~~~~~~
1 error generated.
...failed clang-linux.compile.c++.without-pch bin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/unit_test_parameters.o...
...skipped <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_test_exec_monitor-mt-x64.a(clean) for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>compiler_log_formatter.o...
...skipped <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_test_exec_monitor-mt-x64.a for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>compiler_log_formatter.o...
...skipped <p/work/depends/work/build/x86_64-apple-darwin18/boost/1_70_0-31446f63b81/stage/lib>libboost_test_exec_monitor-mt-x64.a for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_test_exec_monitor-mt-x64.a...
...skipped <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_unit_test_framework-mt-x64.a(clean) for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>compiler_log_formatter.o...
...skipped <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_unit_test_framework-mt-x64.a for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>compiler_log_formatter.o...
...skipped <p/work/depends/work/build/x86_64-apple-darwin18/boost/1_70_0-31446f63b81/stage/lib>libboost_unit_test_framework-mt-x64.a for lack of <pbin.v2/libs/test/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_unit_test_framework-mt-x64.a...
clang-linux.compile.c++.without-pch bin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/gregorian/greg_month.o

  "env" "-u" "C_INCLUDE_PATH" "-u" "CPLUS_INCLUDE_PATH" "-u" "OBJC_INCLUDE_PATH" "-u" "OBJCPLUS_INCLUDE_PATH" "-u" "CPATH" "-u" "LIBRARY_PATH" "/work/depends/x86_64-apple-darwin18/native/bin/clang++" "--target=x86_64-apple-darwin18" "-mmacosx-version-min=10.14" "-B/work/depends/x86_64-apple-darwin18/native/bin" "-mlinker-version=609" "--sysroot=/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers" "-stdlib=libc++" "-nostdinc++" "-Xclang" "-cxx-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include/c++/v1" "-Xclang" "-internal-externc-isystem/work/depends/x86_64-apple-darwin18/native/lib/clang/10.0.1/include" "-Xclang" "-internal-externc-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include" -c -x c++ -fvisibility-inlines-hidden -std=c++17 -fvisibility=hidden   -I/work/depends/x86_64-apple-darwin18/include -m64 -O3 -Wall -fvisibility=hidden -Wno-inline  -DBOOST_ALL_NO_LIB=1 -DDATE_TIME_INLINE -DNDEBUG -I"." -o "bin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/gregorian/greg_month.o" "libs/date_time/src/gregorian/greg_month.cpp"

In file included from libs/date_time/src/gregorian/greg_month.cpp:14:
In file included from ./boost/date_time/gregorian/greg_month.hpp:12:
./boost/date_time/constrained_value.hpp:12:10: fatal error: 'exception' file not found
#include <exception>
         ^~~~~~~~~~~
1 error generated.
...failed clang-linux.compile.c++.without-pch bin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden/gregorian/greg_month.o...
...skipped <pbin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_date_time-mt-x64.a(clean) for lack of <pbin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>gregorian/greg_month.o...
...skipped <pbin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_date_time-mt-x64.a for lack of <pbin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>gregorian/greg_month.o...
...skipped <p/work/depends/work/build/x86_64-apple-darwin18/boost/1_70_0-31446f63b81/stage/lib>libboost_date_time-mt-x64.a for lack of <pbin.v2/libs/date_time/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threading-multi/visibility-hidden>libboost_date_time-mt-x64.a...
clang-linux.compile.c++.without-pch bin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden/pthread/thread.o

  "env" "-u" "C_INCLUDE_PATH" "-u" "CPLUS_INCLUDE_PATH" "-u" "OBJC_INCLUDE_PATH" "-u" "OBJCPLUS_INCLUDE_PATH" "-u" "CPATH" "-u" "LIBRARY_PATH" "/work/depends/x86_64-apple-darwin18/native/bin/clang++" "--target=x86_64-apple-darwin18" "-mmacosx-version-min=10.14" "-B/work/depends/x86_64-apple-darwin18/native/bin" "-mlinker-version=609" "--sysroot=/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers" "-stdlib=libc++" "-nostdinc++" "-Xclang" "-cxx-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include/c++/v1" "-Xclang" "-internal-externc-isystem/work/depends/x86_64-apple-darwin18/native/lib/clang/10.0.1/include" "-Xclang" "-internal-externc-isystem/work/depends/SDKs/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers/usr/include" -c -x c++ -fvisibility-inlines-hidden -std=c++17 -fvisibility=hidden   -I/work/depends/x86_64-apple-darwin18/include -m64 -O3 -Wall -fvisibility=hidden -Wno-inline -Wextra -Wno-long-long -Wno-unused-parameter -Wno-variadic-macros -Wunused-function -DBOOST_ALL_NO_LIB=1 -DBOOST_ATOMIC_STATIC_LINK=1 -DBOOST_THREAD_BUILD_LIB=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -DNDEBUG -I"." -o "bin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden/pthread/thread.o" "libs/thread/src/pthread/thread.cpp"

In file included from libs/thread/src/pthread/thread.cpp:9:
In file included from ./boost/thread/detail/config.hpp:11:
In file included from ./boost/config.hpp:44:
./boost/config/detail/select_stdlib_config.hpp:18:12: fatal error: 'cstddef' file not found
#  include <cstddef>
           ^~~~~~~~~
1 error generated.
...failed clang-linux.compile.c++.without-pch bin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden/pthread/thread.o...
...skipped <pbin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden>libboost_thread-mt-x64.a(clean) for lack of <pbin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden>pthread/thread.o...
...skipped <pbin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden>libboost_thread-mt-x64.a for lack of <pbin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden>pthread/thread.o...
...skipped <p/work/depends/work/build/x86_64-apple-darwin18/boost/1_70_0-31446f63b81/stage/lib>libboost_thread-mt-x64.a for lack of <pbin.v2/libs/thread/build/clang-linux-10.0.1/release/link-static/target-os-darwin/threadapi-pthread/threading-multi/visibility-hidden>libboost_thread-mt-x64.a...
...failed updating 28 targets...
...skipped 18 targets...
...updated 34 targets...
make[1]: *** [funcs.mk:276: /work/depends/work/build/x86_64-apple-darwin18/boost/1_70_0-31446f63b81/./.stamp_built] Error 1
make: *** [Makefile:234: build-osx] Error 2
Build build-osx failed with exit code 2
PiRK retitled this revision from build: Xcode 12.1, macOS SDK 10.15.6 to build: MacOS toolchain bump part 2 (Xcode 12.1, macOS SDK 10.15.6).
PiRK edited the summary of this revision. (Show Details)

squash The rest of the PR and rebase

fix more occurences of Xcode 11.3.1, most importantly in download-apple-sdk.sh

Tail of the build log:

/usr/bin/install -c -m 644 jemalloc.pc /work/depends/work/staging/x86_64-apple-darwin18/jemalloc/5.2.1-ddfa2db66f1/work/depends/x86_64-apple-darwin18/lib/pkgconfig
Missing xsltproc.  doc/jemalloc.html not (re)built.
Missing xsltproc.  doc/jemalloc.3 not (re)built.
/usr/bin/install -c -m 644 doc/jemalloc.html /work/depends/work/staging/x86_64-apple-darwin18/jemalloc/5.2.1-ddfa2db66f1/work/depends/x86_64-apple-darwin18/share/doc/jemalloc
/usr/bin/install -c -m 644 doc/jemalloc.3 /work/depends/work/staging/x86_64-apple-darwin18/jemalloc/5.2.1-ddfa2db66f1/work/depends/x86_64-apple-darwin18/share/man/man3
Postprocessing jemalloc...
Caching jemalloc...
copying packages: native_biplist native_ds_store native_mac_alias native_cctools native_libtapi native_libdmg-hfsplus native_clang native_protobuf boost openssl libevent zlib qt qrencode bdb sqlite miniupnpc libnatpmp protobuf zeromq jemalloc
to: /work/depends/x86_64-apple-darwin18
/work/abc-ci-builds/build-osx
CMake Warning at /usr/share/cmake-3.18/Modules/Platform/Darwin-Initialize.cmake:286 (message):
  Ignoring CMAKE_OSX_SYSROOT value:

   /work/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers

  because the directory does not exist.
Call Stack (most recent call first):
  /usr/share/cmake-3.18/Modules/CMakeSystemSpecificInitialize.cmake:21 (include)
  CMakeLists.txt:9 (project)


-- The C compiler identification is Clang 10.0.1
-- The CXX compiler identification is Clang 10.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /work/depends/x86_64-apple-darwin18/native/bin/clang
-- Check for working C compiler: /work/depends/x86_64-apple-darwin18/native/bin/clang - broken
CMake Error at /usr/share/cmake-3.18/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/work/depends/x86_64-apple-darwin18/native/bin/clang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /work/abc-ci-builds/build-osx/CMakeFiles/CMakeTmp
    
    Run Build Command(s):/usr/bin/ninja cmTC_d223c && [1/2] Building C object CMakeFiles/cmTC_d223c.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_d223c
    FAILED: cmTC_d223c 
    : && /work/depends/x86_64-apple-darwin18/native/bin/clang --target=x86_64-apple-darwin18 -mmacosx-version-min=10.14 -Wl,-headerpad_max_install_names  CMakeFiles/cmTC_d223c.dir/testCCompiler.c.o -o cmTC_d223c   && :
    ld: warning: directory not found for option '-F/System/Library/Frameworks/'
    ld: library not found for -lSystem
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:9 (project)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-osx/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-osx/CMakeFiles/CMakeError.log".
Build build-osx failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/39802 -> phabricator/diff/39802
 * [new tag]             phabricator/diff/39803 -> phabricator/diff/39803
 * [new tag]             phabricator/diff/39804 -> phabricator/diff/39804
 * [new tag]             phabricator/diff/39805 -> phabricator/diff/39805
 * [new tag]             phabricator/diff/39806 -> phabricator/diff/39806
 * [new tag]             phabricator/diff/39813 -> phabricator/diff/39813
 * [new tag]             phabricator/diff/39814 -> phabricator/diff/39814
 * [new tag]             phabricator/diff/39816 -> phabricator/diff/39816
 * [new tag]             phabricator/diff/39817 -> phabricator/diff/39817
 * [new tag]             phabricator/diff/39818 -> phabricator/diff/39818
 * [new tag]             phabricator/diff/39819 -> phabricator/diff/39819
 * [new tag]             phabricator/diff/39843 -> phabricator/diff/39843
 * [new tag]             phabricator/diff/39844 -> phabricator/diff/39844
 * [new tag]             phabricator/diff/39846 -> phabricator/diff/39846
 * [new tag]             phabricator/diff/39847 -> phabricator/diff/39847
 * [new tag]             phabricator/diff/39853 -> phabricator/diff/39853
 * [new tag]             phabricator/diff/39868 -> phabricator/diff/39868
 * [new tag]             phabricator/diff/39871 -> phabricator/diff/39871
 * [new tag]             phabricator/diff/39880 -> phabricator/diff/39880
 * [new tag]             phabricator/diff/39881 -> phabricator/diff/39881
 * [new tag]             phabricator/diff/39885 -> phabricator/diff/39885
 * [new tag]             phabricator/diff/39891 -> phabricator/diff/39891
 * [new tag]             phabricator/diff/39903 -> phabricator/diff/39903
 * [new tag]             phabricator/diff/39908 -> phabricator/diff/39908
 * [new tag]             phabricator/diff/39921 -> phabricator/diff/39921
 * [new tag]             phabricator/diff/39926 -> phabricator/diff/39926
 * [new tag]             phabricator/diff/39928 -> phabricator/diff/39928
 * [new tag]             phabricator/diff/39945 -> phabricator/diff/39945
 * [new tag]             phabricator/diff/39947 -> phabricator/diff/39947
 * [new tag]             phabricator/diff/39958 -> phabricator/diff/39958
 * [new tag]             phabricator/diff/39959 -> phabricator/diff/39959
 * [new tag]             phabricator/diff/39963 -> phabricator/diff/39963
 * [new tag]             phabricator/diff/39970 -> phabricator/diff/39970
 * [new tag]             phabricator/diff/39983 -> phabricator/diff/39983
 * [new tag]             phabricator/diff/39984 -> phabricator/diff/39984
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

rebase after bumping min MacOS version to 10.15

Tail of the build log:

/usr/bin/install -c -m 644 jemalloc.pc /work/depends/work/staging/x86_64-apple-darwin19/jemalloc/5.2.1-a0ac22505c6/work/depends/x86_64-apple-darwin19/lib/pkgconfig
Missing xsltproc.  doc/jemalloc.html not (re)built.
Missing xsltproc.  doc/jemalloc.3 not (re)built.
/usr/bin/install -c -m 644 doc/jemalloc.html /work/depends/work/staging/x86_64-apple-darwin19/jemalloc/5.2.1-a0ac22505c6/work/depends/x86_64-apple-darwin19/share/doc/jemalloc
/usr/bin/install -c -m 644 doc/jemalloc.3 /work/depends/work/staging/x86_64-apple-darwin19/jemalloc/5.2.1-a0ac22505c6/work/depends/x86_64-apple-darwin19/share/man/man3
Postprocessing jemalloc...
Caching jemalloc...
copying packages: native_biplist native_ds_store native_mac_alias native_cctools native_libtapi native_libdmg-hfsplus native_clang native_protobuf boost openssl libevent zlib qt qrencode bdb sqlite miniupnpc libnatpmp protobuf zeromq jemalloc
to: /work/depends/x86_64-apple-darwin19
/work/abc-ci-builds/build-osx
CMake Warning at /usr/share/cmake-3.18/Modules/Platform/Darwin-Initialize.cmake:286 (message):
  Ignoring CMAKE_OSX_SYSROOT value:

   /work/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers

  because the directory does not exist.
Call Stack (most recent call first):
  /usr/share/cmake-3.18/Modules/CMakeSystemSpecificInitialize.cmake:21 (include)
  CMakeLists.txt:9 (project)


-- The C compiler identification is Clang 10.0.1
-- The CXX compiler identification is Clang 10.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /work/depends/x86_64-apple-darwin19/native/bin/clang
-- Check for working C compiler: /work/depends/x86_64-apple-darwin19/native/bin/clang - broken
CMake Error at /usr/share/cmake-3.18/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/work/depends/x86_64-apple-darwin19/native/bin/clang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /work/abc-ci-builds/build-osx/CMakeFiles/CMakeTmp
    
    Run Build Command(s):/usr/bin/ninja cmTC_cf42d && [1/2] Building C object CMakeFiles/cmTC_cf42d.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_cf42d
    FAILED: cmTC_cf42d 
    : && /work/depends/x86_64-apple-darwin19/native/bin/clang --target=x86_64-apple-darwin19 -mmacosx-version-min=10.14 -Wl,-headerpad_max_install_names  CMakeFiles/cmTC_cf42d.dir/testCCompiler.c.o -o cmTC_cf42d   && :
    ld: warning: directory not found for option '-F/System/Library/Frameworks/'
    ld: library not found for -lSystem
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:9 (project)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-osx/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-osx/CMakeFiles/CMakeError.log".
Build build-osx failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/39869 -> phabricator/diff/39869
 * [new tag]             phabricator/diff/39871 -> phabricator/diff/39871
 * [new tag]             phabricator/diff/39880 -> phabricator/diff/39880
 * [new tag]             phabricator/diff/39881 -> phabricator/diff/39881
 * [new tag]             phabricator/diff/39885 -> phabricator/diff/39885
 * [new tag]             phabricator/diff/39886 -> phabricator/diff/39886
 * [new tag]             phabricator/diff/39891 -> phabricator/diff/39891
 * [new tag]             phabricator/diff/39903 -> phabricator/diff/39903
 * [new tag]             phabricator/diff/39904 -> phabricator/diff/39904
 * [new tag]             phabricator/diff/39905 -> phabricator/diff/39905
 * [new tag]             phabricator/diff/39914 -> phabricator/diff/39914
 * [new tag]             phabricator/diff/39921 -> phabricator/diff/39921
 * [new tag]             phabricator/diff/39925 -> phabricator/diff/39925
 * [new tag]             phabricator/diff/39926 -> phabricator/diff/39926
 * [new tag]             phabricator/diff/39928 -> phabricator/diff/39928
 * [new tag]             phabricator/diff/39929 -> phabricator/diff/39929
 * [new tag]             phabricator/diff/39945 -> phabricator/diff/39945
 * [new tag]             phabricator/diff/39947 -> phabricator/diff/39947
 * [new tag]             phabricator/diff/39957 -> phabricator/diff/39957
 * [new tag]             phabricator/diff/39958 -> phabricator/diff/39958
 * [new tag]             phabricator/diff/39959 -> phabricator/diff/39959
 * [new tag]             phabricator/diff/39963 -> phabricator/diff/39963
 * [new tag]             phabricator/diff/39970 -> phabricator/diff/39970
 * [new tag]             phabricator/diff/39971 -> phabricator/diff/39971
 * [new tag]             phabricator/diff/39972 -> phabricator/diff/39972
 * [new tag]             phabricator/diff/39974 -> phabricator/diff/39974
 * [new tag]             phabricator/diff/39977 -> phabricator/diff/39977
 * [new tag]             phabricator/diff/39982 -> phabricator/diff/39982
 * [new tag]             phabricator/diff/39984 -> phabricator/diff/39984
 * [new tag]             phabricator/diff/39987 -> phabricator/diff/39987
 * [new tag]             phabricator/diff/40009 -> phabricator/diff/40009
 * [new tag]             phabricator/diff/40011 -> phabricator/diff/40011
 * [new tag]             phabricator/diff/40012 -> phabricator/diff/40012
 * [new tag]             phabricator/diff/40013 -> phabricator/diff/40013
 * [new tag]             phabricator/diff/40014 -> phabricator/diff/40014
 * [new tag]             phabricator/diff/40015 -> phabricator/diff/40015
 * [new tag]             phabricator/diff/40016 -> phabricator/diff/40016
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

also bump the relevant cmake vars

Tail of the build log:

 * [new tag]             phabricator/diff/39806 -> phabricator/diff/39806
 * [new tag]             phabricator/diff/39813 -> phabricator/diff/39813
 * [new tag]             phabricator/diff/39815 -> phabricator/diff/39815
 * [new tag]             phabricator/diff/39817 -> phabricator/diff/39817
 * [new tag]             phabricator/diff/39822 -> phabricator/diff/39822
 * [new tag]             phabricator/diff/39832 -> phabricator/diff/39832
 * [new tag]             phabricator/diff/39843 -> phabricator/diff/39843
 * [new tag]             phabricator/diff/39845 -> phabricator/diff/39845
 * [new tag]             phabricator/diff/39846 -> phabricator/diff/39846
 * [new tag]             phabricator/diff/39853 -> phabricator/diff/39853
 * [new tag]             phabricator/diff/39865 -> phabricator/diff/39865
 * [new tag]             phabricator/diff/39868 -> phabricator/diff/39868
 * [new tag]             phabricator/diff/39869 -> phabricator/diff/39869
 * [new tag]             phabricator/diff/39871 -> phabricator/diff/39871
 * [new tag]             phabricator/diff/39889 -> phabricator/diff/39889
 * [new tag]             phabricator/diff/39903 -> phabricator/diff/39903
 * [new tag]             phabricator/diff/39904 -> phabricator/diff/39904
 * [new tag]             phabricator/diff/39905 -> phabricator/diff/39905
 * [new tag]             phabricator/diff/39908 -> phabricator/diff/39908
 * [new tag]             phabricator/diff/39918 -> phabricator/diff/39918
 * [new tag]             phabricator/diff/39926 -> phabricator/diff/39926
 * [new tag]             phabricator/diff/39936 -> phabricator/diff/39936
 * [new tag]             phabricator/diff/39945 -> phabricator/diff/39945
 * [new tag]             phabricator/diff/39947 -> phabricator/diff/39947
 * [new tag]             phabricator/diff/39958 -> phabricator/diff/39958
 * [new tag]             phabricator/diff/39959 -> phabricator/diff/39959
 * [new tag]             phabricator/diff/39963 -> phabricator/diff/39963
 * [new tag]             phabricator/diff/39982 -> phabricator/diff/39982
 * [new tag]             phabricator/diff/39983 -> phabricator/diff/39983
 * [new tag]             phabricator/diff/39986 -> phabricator/diff/39986
 * [new tag]             phabricator/diff/40009 -> phabricator/diff/40009
 * [new tag]             phabricator/diff/40011 -> phabricator/diff/40011
 * [new tag]             phabricator/diff/40012 -> phabricator/diff/40012
 * [new tag]             phabricator/diff/40013 -> phabricator/diff/40013
 * [new tag]             phabricator/diff/40014 -> phabricator/diff/40014
 * [new tag]             phabricator/diff/40015 -> phabricator/diff/40015
 * [new tag]             phabricator/diff/40019 -> phabricator/diff/40019
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1
PiRK retitled this revision from build: MacOS toolchain bump part 2 (Xcode 12.1, macOS SDK 10.15.6) to build: MacOS toolchain bump.
PiRK edited the summary of this revision. (Show Details)

squash with D13805 and D13788

rebase and fix a quasi-conflict (adjacent lines being changed) with D13790

This arc diff was submitted with --nolint because of unrelated linter errors (looks like prettier wants to lint all the documentation, including release notes)

PiRK published this revision for review.Apr 27 2023, 13:38

@bot gitian-osx

Fabien requested changes to this revision.Apr 27 2023, 14:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/guix/README.md
67 ↗(On Diff #40029)

revert

109 ↗(On Diff #40029)
173 ↗(On Diff #40029)
198 ↗(On Diff #40029)

nope

doc/gitian-building/gitian-building-mac-os-sdk.md
4 ↗(On Diff #40029)
This revision now requires changes to proceed.Apr 27 2023, 14:00
contrib/guix/README.md
109 ↗(On Diff #40029)

OK but it will be reverted again soonish (https://github.com/bitcoin/bitcoin/pull/23585)

review (doc only changes)

This revision is now accepted and ready to land.Apr 28 2023, 07:43
This revision was automatically updated to reflect the committed changes.