Differential D1379

[cmake] Do not assume ninja
ClosedPublic
Actions

Authored by deadalnix on May 6 2018, 13:50.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING8d2ddaa7c189: [cmake] Do not assume ninja
rABC8d2ddaa7c189: [cmake] Do not assume ninja

Summary

Currently, cmake always use ninja to build native executable. This patch changes this to use the same generator as the one provided by the user.

Test Plan

cmake .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake
make
cmake .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake
make

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmakegenerator

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2531
Build 3182: Bitcoin ABC Buildbot (legacy)
Build 3181: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 6 2018, 13:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2018, 13:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2531: Diff 3797.May 6 2018, 14:13

LGTM

This revision is now accepted and ready to land.May 6 2018, 16:42

Closed by commit rABC8d2ddaa7c189: [cmake] Do not assume ninja (authored by deadalnix). · Explain WhyMay 6 2018, 20:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

NativeExecutable.cmake

11 lines

Diff 3797

View Options

cmake/modules/NativeExecutable.cmake

[cmake] Do not assume ninjaClosedPublicActions