Differential D13804

Fix the filesystem library check on GCC8 and Clang8
ClosedPublic
Actions

Authored by Fabien on Apr 27 2023, 09:07.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC2b4fd8699d80: Fix the filesystem library check on GCC8 and Clang8

Summary

Using the linker flags is not good for every version as it really is
an optional library. This diff makes this more correct and avoid build
failures/warnings for some older compiler versions (especially GCC8 on
Debian Buster).

Test Plan

With GCC8 and Clang8 (on Debian Buster):

ninja all check

Note: for the clang-8 build to succeed you need D13803.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 27 2023, 09:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2023, 09:07

Fabien requested review of this revision.Apr 27 2023, 09:07

PiRK accepted this revision.Apr 27 2023, 09:15

This revision is now accepted and ready to land.Apr 27 2023, 09:15

Harbormaster completed remote builds in B23511: Diff 40012.Apr 27 2023, 09:26

Closed by commit rABC2b4fd8699d80: Fix the filesystem library check on GCC8 and Clang8 (authored by Fabien). · Explain WhyApr 27 2023, 09:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2b4fd8699d80: Fix the filesystem library check on GCC8 and Clang8.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

10 lines

Diff 40018

View Options

Fix the filesystem library check on GCC8 and Clang8ClosedPublicActions